Skip to content

test(snapshots): migrate lint-*/oxlint-* cases to the PTY snapshot suite#2131

Merged
graphite-app[bot] merged 1 commit into
mainfrom
migrate-lint-snap-tests
Jul 10, 2026
Merged

test(snapshots): migrate lint-*/oxlint-* cases to the PTY snapshot suite#2131
graphite-app[bot] merged 1 commit into
mainfrom
migrate-lint-snap-tests

Conversation

@fengmk2

@fengmk2 fengmk2 commented Jul 10, 2026

Copy link
Copy Markdown
Member

Migrates the 6 lint cases (ignore patterns, unmatched pattern, vite config rules, vite-plus import rules, nuxt variant, type-aware) from packages/cli/snap-tests to the PTY snapshot suite, and removes the legacy dirs. Part of #2116.

oxlint-typeaware needed hand conversion: its echo //comment >> types.ts appends became vpt write-file with the full appended content, and its legacy ignoredPlatforms: [""] (matches nothing) was translated verbatim to skip-platforms = [""], which the new runner's platform parser rejects; dropped. The recorded snapshot proves the type-aware distinction: non-type-aware lint shows cache hit after the types.ts change, type-aware shows cache miss: 'types.ts' modified.

Adds a redaction rule masking oxlint's with N rules count, which grows on every bundled oxlint upgrade (the legacy suite masked it the same way).

@netlify

netlify Bot commented Jul 10, 2026

Copy link
Copy Markdown

Deploy Preview for viteplus-preview canceled.

Name Link
🔨 Latest commit e40e85f
🔍 Latest deploy log https://app.netlify.com/projects/viteplus-preview/deploys/6a50a80602fed30008d7f115

fengmk2 commented Jul 10, 2026

Copy link
Copy Markdown
Member Author

How to use the Graphite Merge Queue

Add the label auto-merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@fengmk2 fengmk2 force-pushed the migrate-lint-snap-tests branch from b46b996 to 2608f7e Compare July 10, 2026 02:32
@fengmk2 fengmk2 marked this pull request as ready for review July 10, 2026 02:36
@fengmk2 fengmk2 self-assigned this Jul 10, 2026
@fengmk2 fengmk2 requested a review from wan9chi July 10, 2026 02:36
@fengmk2 fengmk2 force-pushed the migrate-lint-snap-tests branch from 2608f7e to bc4184c Compare July 10, 2026 04:13
@fengmk2 fengmk2 changed the title fix(snapshots): scope registry teardown signal test(snapshots): migrate lint-*/oxlint-* cases to the PTY snapshot suite Jul 10, 2026
@fengmk2 fengmk2 force-pushed the migrate-lint-snap-tests branch 2 times, most recently from d1cada5 to a8e8173 Compare July 10, 2026 06:38
@graphite-app

graphite-app Bot commented Jul 10, 2026

Copy link
Copy Markdown

Merge activity

…t suite (#2131)

Migrates the 6 lint cases (ignore patterns, unmatched pattern, vite config rules, vite-plus import rules, nuxt variant, type-aware) from `packages/cli/snap-tests` to the PTY snapshot suite, and removes the legacy dirs. Part of #2116.

`oxlint-typeaware` needed hand conversion: its `echo //comment >> types.ts` appends became `vpt write-file` with the full appended content, and its legacy `ignoredPlatforms: [""]` (matches nothing) was translated verbatim to `skip-platforms = [""]`, which the new runner's platform parser rejects; dropped. The recorded snapshot proves the type-aware distinction: non-type-aware lint shows `cache hit` after the types.ts change, type-aware shows `cache miss: 'types.ts' modified`.

Adds a redaction rule masking oxlint's `with N rules` count, which grows on every bundled oxlint upgrade (the legacy suite masked it the same way).
@graphite-app graphite-app Bot force-pushed the migrate-lint-snap-tests branch from a8e8173 to e40e85f Compare July 10, 2026 08:06
@graphite-app graphite-app Bot merged commit e40e85f into main Jul 10, 2026
52 checks passed
@graphite-app graphite-app Bot deleted the migrate-lint-snap-tests branch July 10, 2026 08:12
wan9chi added a commit that referenced this pull request Jul 16, 2026
)

Release vite-plus v0.2.5: Cleaner environments and more reliable
workflows.

This release adds cleanup and package version commands, supports
TypeScript 7 declaration generation, reduces the standalone binary size,
and hardens task tracking, CLI output, package-manager routing, Docker
workflows, and project scaffolding.

### Highlights

- Add `vp env clean` to remove unused managed Node.js runtimes and
package-manager caches
([#2003](#2003)), by
@liangmiQwQ
- Add `vp pm version`, forwarding native version commands to npm, pnpm,
Yarn, and Bun
([#2127](#2127)), by
@jong-kyung
- Add TypeScript 7 support to declaration generation and generated
library projects with tsdown `0.22.7`
([#2104](#2104),
[#2168](#2168)), by
@wan9chi
- Improve automatic task input tracking for Bun on macOS, Linux
containers with constrained `/dev/shm`, and Windows process images,
reduce Windows backing-file allocation, and clarify task wait failures
([vite-task#515](voidzero-dev/vite-task#515),
[vite-task#518](voidzero-dev/vite-task#518),
[vite-task#523](voidzero-dev/vite-task#523),
[vite-task#524](voidzero-dev/vite-task#524),
[vite-task#542](voidzero-dev/vite-task#542),
[#2126](#2126),
[#2167](#2167)), by
@wan9chi
- Prevent CLI diagnostics from truncating or panicking when inherited
standard output or error is nonblocking
([#2172](#2172),
[#2173](#2173)), by
@wan9chi

### Fixes & Enhancements

- Reduce standalone `vp` binary sizes by about 5% on Linux and macOS and
19% on Windows
([#2043](#2043)), by
@fengmk2
- Keep the Docker image non-root by default while allowing passwordless
`sudo` for Playwright browser dependencies and system packages
([#2088](#2088)), by
@fengmk2
- Ignore `.env` and `.env.*` in generated projects while keeping
`.env.example` trackable
([#2095](#2095)), by
@forehalo
- Create `vp-use.cmd` after the Windows environment bin directory is
ready and document its Command Prompt-only usage
([#2128](#2128)), by
@liangmiQwQ
- Render user-facing process statuses and paths without Rust debug
wrappers ([#2130](#2130)),
by @liangmiQwQ
- Make `vp dedupe` fall back to `yarn install` with a warning on Yarn
Classic ([#2139](#2139)),
by @jong-kyung
- Ensure package-manager child processes, including Bun, can always find
the managed Node.js runtime
([#2158](#2158)), by
@BlankParticle

### Docs

- Update the release-manager post-release guidance
([#2096](#2096)), by
@wan9chi
- Add Windows to the Namespace sponsor credit
([#2108](#2108)), by
@fengmk2
- Document installer and runtime environment variables, registry
settings, TLS options, and precedence rules
([#2114](#2114)), by
@yukinoshi
- Mark shell examples in `CONTRIBUTING.md` as Bash code blocks
([#2159](#2159)), by
@BlankParticle

### Chore

- Assign prepared release PRs to the workflow actor
([#2094](#2094)), by
@wan9chi
- Complete the PTY snapshot migration and harden the runner, fixtures,
release-version redaction, registry teardown, timeouts, and Linux
parallelism
([#2071](#2071),
[#2080](#2080),
[#2084](#2084),
[#2099](#2099),
[#2102](#2102),
[#2103](#2103),
[#2107](#2107),
[#2109](#2109),
[#2115](#2115),
[#2117](#2117),
[#2118](#2118),
[#2119](#2119),
[#2120](#2120),
[#2121](#2121),
[#2131](#2131),
[#2132](#2132),
[#2134](#2134),
[#2137](#2137),
[#2138](#2138),
[#2141](#2141),
[#2143](#2143),
[#2145](#2145),
[#2182](#2182)), by
@fengmk2 and @wan9chi
- Expose Vite+ managed binaries consistently inside snapshot fixtures
([#2110](#2110)), by
@liangmiQwQ
- Exclude PTY snapshot configuration from Vitest discovery and remove
the legacy snapshot infrastructure
([#2135](#2135),
[#2146](#2146)), by
@jong-kyung
- Modernize Windows runners, registry bridge publishing, native size
reporting, merge-base comparisons, and package-manager installation CI
([#2083](#2083),
[#2100](#2100),
[#2105](#2105),
[#2106](#2106),
[#2112](#2112),
[#2133](#2133)), by
@fengmk2
- Verify that created monorepo libraries emit declarations in CI
([#2171](#2171)), by
@wan9chi

### Bundled Versions

| Tool | Version | Source |
| --------------- | ------- |
-----------------------------------------------------------------------
|
| vite | `8.1.4` |
[`a477454`](vitejs/vite@a477454)
|
| rolldown | `1.1.5` |
[`f09947a`](rolldown/rolldown@f09947a)
|
| tsdown | `0.22.7` | [npm](https://npmx.dev/package/tsdown/v/0.22.7) |
| vitest | `4.1.10` | [npm](https://npmx.dev/package/vitest/v/4.1.10) |
| oxlint | `1.73.0` | [npm](https://npmx.dev/package/oxlint/v/1.73.0) |
| oxlint-tsgolint | `0.24.0` |
[npm](https://npmx.dev/package/oxlint-tsgolint/v/0.24.0) |
| oxfmt | `0.58.0` | [npm](https://npmx.dev/package/oxfmt/v/0.58.0) |

### Upgrade

```bash
vp upgrade
```

### New Contributors

Welcome @yukinoshi and @BlankParticle.

**Full Changelog**:
v0.2.4...v0.2.5

---

Merging this PR will trigger the release workflow.

---------

Co-authored-by: voidzero-guard[bot] <278573678+voidzero-guard[bot]@users.noreply.github.com>
Co-authored-by: wan9chi <dk4rest@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants