test(snapshots): bound the PTY spawn with the per-step timeout by fengmk2 · Pull Request #2102 · voidzero-dev/vite-plus

fengmk2 · 2026-07-09T01:07:43Z

The per-step timeout only wrapped the interaction phase (rx.recv_timeout): TestTerminal::spawn (openpty + fork/exec the child into the PTY) ran synchronously before it. On runners where that spawn can block (the Linux analog of the ConPTY blocking that keeps the Windows snapshot job on a GitHub-hosted runner), a wedged spawn was unbounded, and because the parallel execution gate holds the case's lease, it stalled the whole suite (6h job default, no step log).

Run the spawn on a helper thread bounded by the same per-step timeout: a wedged spawn now fails that one case, like any other step timeout, and the suite proceeds. The success path is unchanged (verified against the interactive picker cases). The abandoned helper thread is fine for a dev-only test binary that exits when the run ends.

What a wedged spawn looks like now

Forcing the spawn to block (the failure this fixes), the case now fails at its per-step timeout instead of hanging the run:

---- app_root_listing::picker_select::global ----
step `vp build` timed out after 2s; partial output:
(PTY spawn did not complete)

failures:
    app_root_listing::picker_select::global

test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 84 filtered out; finished in 2.02s

(2s is a shortened demo timeout; the real per-step default is 50s. The other cases keep running and the step log is preserved, versus the old behavior where this same block hung the whole step until the 6h job default with no log.)

netlify · 2026-07-09T01:07:50Z

✅ Deploy Preview for viteplus-preview canceled.

Name	Link
🔨 Latest commit	`0789c79`
🔍 Latest deploy log	https://app.netlify.com/projects/viteplus-preview/deploys/6a4f0aaa0e81a00008416e89

fengmk2 · 2026-07-09T01:07:56Z

How to use the Graphite Merge Queue

Add the label auto-merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

fengmk2 · 2026-07-09T01:18:46Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e16a7cf38f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

fengmk2 · 2026-07-09T01:40:11Z

@codex review

chatgpt-codex-connector · 2026-07-09T01:43:45Z

Codex Review: Didn't find any major issues. 👍

Reviewed commit: 512c75f29d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

The per-step timeout only wrapped the interaction phase (rx.recv_timeout): TestTerminal::spawn (openpty + fork/exec the child into the PTY) ran synchronously before it. On runners where that spawn can block (the Linux analog of the ConPTY blocking that keeps the Windows snapshot job on a GitHub-hosted runner), a wedged spawn was unbounded, and because the parallel execution gate holds the case's lease, it stalled the whole suite (6h job default, no step log). Run the spawn on a helper thread bounded by the same per-step timeout: a wedged spawn now fails that one case (like any other step timeout) and the suite proceeds. Success path is unchanged (verified against the interactive picker cases). The helper thread is abandoned on timeout, which is fine for a dev-only test binary that exits when the run ends.

If the spawn wait times out and the helper thread's TestTerminal::spawn still succeeds afterwards, the send fails and the terminal was dropped without killing its child (TestTerminal has no Drop that kills). Handle the SendError and kill the child so a slow-but-live command cannot keep running after the case has already failed.

wan9chi · 2026-07-09T02:45:58Z

You can consider writing the timeout in the snapshot like: https://github.com/voidzero-dev/vite-task/blob/cda404d1f12cb9fa4a73f93bd863a636ebc4dcd9/crates/vite_task_bin/tests/e2e_snapshots/main.rs#L584

This way the previous outputs will be naturally written in the snapshot.

The recurring Linux snapshot hang survives #2102's spawn bound (a run that contained the bound still wedged for the full 10-min step timeout), so the wedge is at a different, still-unbounded point (or cumulative create-test timeouts around the ctrl-c case). Add snap_trace (gated on VP_SNAP_TRACE=1), writing START/phase/END lines straight to fd 2 so they survive libtest capture and reach the CI log even when the step is killed by its timeout. A step that logs START without END is the wedged one, and the phase markers (spawn dispatched / spawned / waiting for exit) localize within it. Enable it on the Linux PTY CI step; off by default everywhere else.

@liangmiQwQ

) Release vite-plus v0.2.5: Cleaner environments and more reliable workflows. This release adds cleanup and package version commands, supports TypeScript 7 declaration generation, reduces the standalone binary size, and hardens task tracking, CLI output, package-manager routing, Docker workflows, and project scaffolding. ### Highlights - Add `vp env clean` to remove unused managed Node.js runtimes and package-manager caches ([#2003](#2003)), by @liangmiQwQ - Add `vp pm version`, forwarding native version commands to npm, pnpm, Yarn, and Bun ([#2127](#2127)), by @jong-kyung - Add TypeScript 7 support to declaration generation and generated library projects with tsdown `0.22.7` ([#2104](#2104), [#2168](#2168)), by @wan9chi - Improve automatic task input tracking for Bun on macOS, Linux containers with constrained `/dev/shm`, and Windows process images, reduce Windows backing-file allocation, and clarify task wait failures ([vite-task#515](voidzero-dev/vite-task#515), [vite-task#518](voidzero-dev/vite-task#518), [vite-task#523](voidzero-dev/vite-task#523), [vite-task#524](voidzero-dev/vite-task#524), [vite-task#542](voidzero-dev/vite-task#542), [#2126](#2126), [#2167](#2167)), by @wan9chi - Prevent CLI diagnostics from truncating or panicking when inherited standard output or error is nonblocking ([#2172](#2172), [#2173](#2173)), by @wan9chi ### Fixes & Enhancements - Reduce standalone `vp` binary sizes by about 5% on Linux and macOS and 19% on Windows ([#2043](#2043)), by @fengmk2 - Keep the Docker image non-root by default while allowing passwordless `sudo` for Playwright browser dependencies and system packages ([#2088](#2088)), by @fengmk2 - Ignore `.env` and `.env.*` in generated projects while keeping `.env.example` trackable ([#2095](#2095)), by @forehalo - Create `vp-use.cmd` after the Windows environment bin directory is ready and document its Command Prompt-only usage ([#2128](#2128)), by @liangmiQwQ - Render user-facing process statuses and paths without Rust debug wrappers ([#2130](#2130)), by @liangmiQwQ - Make `vp dedupe` fall back to `yarn install` with a warning on Yarn Classic ([#2139](#2139)), by @jong-kyung - Ensure package-manager child processes, including Bun, can always find the managed Node.js runtime ([#2158](#2158)), by @BlankParticle ### Docs - Update the release-manager post-release guidance ([#2096](#2096)), by @wan9chi - Add Windows to the Namespace sponsor credit ([#2108](#2108)), by @fengmk2 - Document installer and runtime environment variables, registry settings, TLS options, and precedence rules ([#2114](#2114)), by @yukinoshi - Mark shell examples in `CONTRIBUTING.md` as Bash code blocks ([#2159](#2159)), by @BlankParticle ### Chore - Assign prepared release PRs to the workflow actor ([#2094](#2094)), by @wan9chi - Complete the PTY snapshot migration and harden the runner, fixtures, release-version redaction, registry teardown, timeouts, and Linux parallelism ([#2071](#2071), [#2080](#2080), [#2084](#2084), [#2099](#2099), [#2102](#2102), [#2103](#2103), [#2107](#2107), [#2109](#2109), [#2115](#2115), [#2117](#2117), [#2118](#2118), [#2119](#2119), [#2120](#2120), [#2121](#2121), [#2131](#2131), [#2132](#2132), [#2134](#2134), [#2137](#2137), [#2138](#2138), [#2141](#2141), [#2143](#2143), [#2145](#2145), [#2182](#2182)), by @fengmk2 and @wan9chi - Expose Vite+ managed binaries consistently inside snapshot fixtures ([#2110](#2110)), by @liangmiQwQ - Exclude PTY snapshot configuration from Vitest discovery and remove the legacy snapshot infrastructure ([#2135](#2135), [#2146](#2146)), by @jong-kyung - Modernize Windows runners, registry bridge publishing, native size reporting, merge-base comparisons, and package-manager installation CI ([#2083](#2083), [#2100](#2100), [#2105](#2105), [#2106](#2106), [#2112](#2112), [#2133](#2133)), by @fengmk2 - Verify that created monorepo libraries emit declarations in CI ([#2171](#2171)), by @wan9chi ### Bundled Versions | Tool | Version | Source | | --------------- | ------- | ----------------------------------------------------------------------- | | vite | `8.1.4` | [`a477454`](vitejs/vite@a477454) | | rolldown | `1.1.5` | [`f09947a`](rolldown/rolldown@f09947a) | | tsdown | `0.22.7` | [npm](https://npmx.dev/package/tsdown/v/0.22.7) | | vitest | `4.1.10` | [npm](https://npmx.dev/package/vitest/v/4.1.10) | | oxlint | `1.73.0` | [npm](https://npmx.dev/package/oxlint/v/1.73.0) | | oxlint-tsgolint | `0.24.0` | [npm](https://npmx.dev/package/oxlint-tsgolint/v/0.24.0) | | oxfmt | `0.58.0` | [npm](https://npmx.dev/package/oxfmt/v/0.58.0) | ### Upgrade ```bash vp upgrade ``` ### New Contributors Welcome @yukinoshi and @BlankParticle. **Full Changelog**: v0.2.4...v0.2.5 --- Merging this PR will trigger the release workflow. --------- Co-authored-by: voidzero-guard[bot] <278573678+voidzero-guard[bot]@users.noreply.github.com> Co-authored-by: wan9chi <dk4rest@gmail.com>

chatgpt-codex-connector Bot reviewed Jul 9, 2026

View reviewed changes

Comment thread crates/vite_cli_snapshots/tests/cli_snapshots/main.rs Outdated

fengmk2 changed the base branch from main to graphite-base/2102 July 9, 2026 01:31

fengmk2 force-pushed the fix/pty-spawn-timeout branch from e16a7cf to a7957d7 Compare July 9, 2026 01:31

fengmk2 changed the base branch from graphite-base/2102 to fix/redact-scaffold-pm-version July 9, 2026 01:31

fengmk2 mentioned this pull request Jul 9, 2026

test(snapshots): redact scaffolded devEngines version pins #2103

Merged

graphite-app Bot changed the base branch from fix/redact-scaffold-pm-version to graphite-base/2102 July 9, 2026 01:40

graphite-app Bot force-pushed the graphite-base/2102 branch from 0f0a211 to ab7f35b Compare July 9, 2026 01:48

graphite-app Bot force-pushed the fix/pty-spawn-timeout branch from 512c75f to 122bd41 Compare July 9, 2026 01:48

graphite-app Bot changed the base branch from graphite-base/2102 to main July 9, 2026 01:49

graphite-app Bot force-pushed the fix/pty-spawn-timeout branch from 122bd41 to f1f780b Compare July 9, 2026 01:49

fengmk2 added 2 commits July 9, 2026 09:59

fengmk2 force-pushed the fix/pty-spawn-timeout branch from f1f780b to 504379f Compare July 9, 2026 02:00

fengmk2 marked this pull request as ready for review July 9, 2026 02:11

fengmk2 self-assigned this Jul 9, 2026

fengmk2 requested a review from wan9chi July 9, 2026 02:11

Merge branch 'main' into fix/pty-spawn-timeout

281437a

fengmk2 requested a review from cpojer July 9, 2026 02:34

Merge branch 'main' into fix/pty-spawn-timeout

0789c79

wan9chi approved these changes Jul 9, 2026

View reviewed changes

fengmk2 merged commit fd4144b into main Jul 9, 2026
52 checks passed

fengmk2 deleted the fix/pty-spawn-timeout branch July 9, 2026 02:50

wan9chi mentioned this pull request Jul 15, 2026

release: v0.2.5: Cleaner environments and more reliable workflows #2180

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

test(snapshots): bound the PTY spawn with the per-step timeout#2102

test(snapshots): bound the PTY spawn with the per-step timeout#2102
fengmk2 merged 4 commits into
mainfrom
fix/pty-spawn-timeout

fengmk2 commented Jul 9, 2026 •

edited

Loading

Uh oh!

netlify Bot commented Jul 9, 2026 •

edited

Loading

Uh oh!

fengmk2 commented Jul 9, 2026 •

edited

Loading

Uh oh!

fengmk2 commented Jul 9, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

fengmk2 commented Jul 9, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jul 9, 2026

Uh oh!

wan9chi commented Jul 9, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

fengmk2 commented Jul 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What a wedged spawn looks like now

Uh oh!

netlify Bot commented Jul 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for viteplus-preview canceled.

Uh oh!

fengmk2 commented Jul 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

fengmk2 commented Jul 9, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

fengmk2 commented Jul 9, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jul 9, 2026

Uh oh!

wan9chi commented Jul 9, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

fengmk2 commented Jul 9, 2026 •

edited

Loading

netlify Bot commented Jul 9, 2026 •

edited

Loading

fengmk2 commented Jul 9, 2026 •

edited

Loading