test(snapshots): expose Vite+ managed binaries with `vp env setup` by liangmiQwQ · Pull Request #2110 · voidzero-dev/vite-plus

liangmiQwQ · 2026-07-09T11:17:54Z

At present, the PTY runner will find the needed binaries like node, and inject these directories directly into PATH.

This can cause problem, if the users are already using Vite+, it might leak the node shim in the user's original VP_HOME, triggering Node.js re-fetching and behavior-differences, it also makes seed_runtime invalid. There are more problems, like missing the real vp binary will cause incomplete functionality, npm version is not locked, corepack is missing etc.

This PR refactors this part. We simulate the true VP_HOME structure, installing the vp binary into VP_HOME/current/bin with hardlink, put the local cli into VP_HOME/current/node_modules/vite-plus, then run vp setup to generate bins, finally expose the bins according to the flavor.

It also removes the stale tool whitelist, all the bins in the bin directory are accessible. Not only does this allow us to migrate global package related tests here in the future, but it also reduces the maintenance costs.

🤖 Generated with Codex

netlify · 2026-07-09T11:17:59Z

✅ Deploy Preview for viteplus-preview ready!

Name	Link
🔨 Latest commit	`f619174`
🔍 Latest deploy log	https://app.netlify.com/projects/viteplus-preview/deploys/6a505ec7d723c8000866dc62
😎 Deploy Preview	https://deploy-preview-2110--viteplus-preview.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
🤖 Make changes	Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

liangmiQwQ · 2026-07-09T11:18:11Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0b5f3fd63a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

liangmiQwQ · 2026-07-09T11:30:23Z

@fengmk2 While working on #2003, I found that the PTY test just simply use which to find Node and related binaries and put the directory into PATH, is that intentional? Would it make sense to run vp env setup and use <case>/home/.vite-plus/bin?

fengmk2 · 2026-07-09T11:50:26Z

@liangmiQwQ We need to consider network speed. Is it possible to make it configurable? The default is still the original processing method, and then you can configure it to be enabled for your scenario.

liangmiQwQ · 2026-07-09T12:08:06Z

@fengmk2 We've already had seed_runtime so there should not be any network fetching by default, right? So creating shim itself should not take too much time?

fengmk2 · 2026-07-09T12:09:26Z

Then go ahead and refactor it according to your plan. If there's no increase in runtime, there's no problem.

liangmiQwQ · 2026-07-09T12:11:14Z

Would it make sense to run vp env setup and use <case>/home/.vite-plus/bin?

At present, Vite+ PTY snap tests only allow tools run in the allowlist, so installed global packages are also disallowed to run. If we do this change, we can just simply allow all tools in <case>/home/.vite-plus/bin for global flavor, and it will also reduce the maintaining pressure. Would it bring another benefit 😄

fengmk2 · 2026-07-09T12:14:52Z

@liangmiQwQ No problem, the whitelist is a bit over-engineered right now, which has made it unnecessarily complex.

liangmiQwQ · 2026-07-09T14:45:03Z

Nice, it almost works! I will simplify the implementation and do some validation tomorrow 😄

liangmiQwQ · 2026-07-09T23:48:13Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 38f4701d86

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

…epack-snap-allowlist # Conflicts: # crates/vite_cli_snapshots/tests/cli_snapshots/main.rs

fengmk2

@liangmiQwQ Good job!

Migrates 9 of the 10 npm-global shim cases (global npm install/uninstall link behavior) from packages/cli/snap-tests-global, unblocked by #2110 removing the step program allow-list. Runner/vpt additions the cases need: - `vpt stat-file` gains a `symlink` state (via symlink_metadata, shell `test -L` semantics) so link assertions keep their predicate fidelity; no existing baseline stats a symlink. - vpt expands a leading `$NAME` env reference in its arguments (`$VP_HOME/bin/x`), replacing the shell expansion the legacy runner provided; unset variables stay verbatim. - The per-case npm global prefix joins the redaction paths as `<npm-prefix>` (a sibling of `home`, so the `<home>` pair never matched it; `npm config get prefix` prints it). - New WHICH_NODE_VERSION_RE masks `vp env which`'s `Node:` field and the BinConfig `"nodeVersion"` value, which track the environment's managed default runtime rather than a fixture pin. The npm install/uninstall steps run with `tty = false`: under a PTY the npm shim's link-hint path probes the terminal and blocks on a reply the vt100 emulator never sends, while the legacy runner always piped stdio. npm-global-install-custom-prefix-on-path stays in the legacy tree: its `PATH=$(pwd)/...:$PATH` dynamic prefix is not expressible without a shell. Part of #2116.

…te (#2134) Migrates 9 of the 10 npm-global shim cases (global npm install/uninstall link behavior) from packages/cli/snap-tests-global, unblocked by #2110 removing the step program allow-list. Runner/vpt additions the cases need: - `vpt stat-file` gains a `symlink` state (via symlink_metadata, shell `test -L` semantics) so link assertions keep their predicate fidelity; no existing baseline stats a symlink. - vpt expands a leading `$NAME` env reference in its arguments (`$VP_HOME/bin/x`), replacing the shell expansion the legacy runner provided; unset variables stay verbatim. - The per-case npm global prefix joins the redaction paths as `<npm-prefix>` (a sibling of `home`, so the `<home>` pair never matched it; `npm config get prefix` prints it). - New WHICH_NODE_VERSION_RE masks `vp env which`'s `Node:` field and the BinConfig `"nodeVersion"` value, which track the environment's managed default runtime rather than a fixture pin. The npm install/uninstall steps run with `tty = false`: under a PTY the npm shim's link-hint path probes the terminal and blocks on a reply the vt100 emulator never sends, while the legacy runner always piped stdio. npm-global-install-custom-prefix-on-path stays in the legacy tree: its `PATH=$(pwd)/...:$PATH` dynamic prefix is not expressible without a shell. Part of #2116.

@liangmiQwQ

) Release vite-plus v0.2.5: Cleaner environments and more reliable workflows. This release adds cleanup and package version commands, supports TypeScript 7 declaration generation, reduces the standalone binary size, and hardens task tracking, CLI output, package-manager routing, Docker workflows, and project scaffolding. ### Highlights - Add `vp env clean` to remove unused managed Node.js runtimes and package-manager caches ([#2003](#2003)), by @liangmiQwQ - Add `vp pm version`, forwarding native version commands to npm, pnpm, Yarn, and Bun ([#2127](#2127)), by @jong-kyung - Add TypeScript 7 support to declaration generation and generated library projects with tsdown `0.22.7` ([#2104](#2104), [#2168](#2168)), by @wan9chi - Improve automatic task input tracking for Bun on macOS, Linux containers with constrained `/dev/shm`, and Windows process images, reduce Windows backing-file allocation, and clarify task wait failures ([vite-task#515](voidzero-dev/vite-task#515), [vite-task#518](voidzero-dev/vite-task#518), [vite-task#523](voidzero-dev/vite-task#523), [vite-task#524](voidzero-dev/vite-task#524), [vite-task#542](voidzero-dev/vite-task#542), [#2126](#2126), [#2167](#2167)), by @wan9chi - Prevent CLI diagnostics from truncating or panicking when inherited standard output or error is nonblocking ([#2172](#2172), [#2173](#2173)), by @wan9chi ### Fixes & Enhancements - Reduce standalone `vp` binary sizes by about 5% on Linux and macOS and 19% on Windows ([#2043](#2043)), by @fengmk2 - Keep the Docker image non-root by default while allowing passwordless `sudo` for Playwright browser dependencies and system packages ([#2088](#2088)), by @fengmk2 - Ignore `.env` and `.env.*` in generated projects while keeping `.env.example` trackable ([#2095](#2095)), by @forehalo - Create `vp-use.cmd` after the Windows environment bin directory is ready and document its Command Prompt-only usage ([#2128](#2128)), by @liangmiQwQ - Render user-facing process statuses and paths without Rust debug wrappers ([#2130](#2130)), by @liangmiQwQ - Make `vp dedupe` fall back to `yarn install` with a warning on Yarn Classic ([#2139](#2139)), by @jong-kyung - Ensure package-manager child processes, including Bun, can always find the managed Node.js runtime ([#2158](#2158)), by @BlankParticle ### Docs - Update the release-manager post-release guidance ([#2096](#2096)), by @wan9chi - Add Windows to the Namespace sponsor credit ([#2108](#2108)), by @fengmk2 - Document installer and runtime environment variables, registry settings, TLS options, and precedence rules ([#2114](#2114)), by @yukinoshi - Mark shell examples in `CONTRIBUTING.md` as Bash code blocks ([#2159](#2159)), by @BlankParticle ### Chore - Assign prepared release PRs to the workflow actor ([#2094](#2094)), by @wan9chi - Complete the PTY snapshot migration and harden the runner, fixtures, release-version redaction, registry teardown, timeouts, and Linux parallelism ([#2071](#2071), [#2080](#2080), [#2084](#2084), [#2099](#2099), [#2102](#2102), [#2103](#2103), [#2107](#2107), [#2109](#2109), [#2115](#2115), [#2117](#2117), [#2118](#2118), [#2119](#2119), [#2120](#2120), [#2121](#2121), [#2131](#2131), [#2132](#2132), [#2134](#2134), [#2137](#2137), [#2138](#2138), [#2141](#2141), [#2143](#2143), [#2145](#2145), [#2182](#2182)), by @fengmk2 and @wan9chi - Expose Vite+ managed binaries consistently inside snapshot fixtures ([#2110](#2110)), by @liangmiQwQ - Exclude PTY snapshot configuration from Vitest discovery and remove the legacy snapshot infrastructure ([#2135](#2135), [#2146](#2146)), by @jong-kyung - Modernize Windows runners, registry bridge publishing, native size reporting, merge-base comparisons, and package-manager installation CI ([#2083](#2083), [#2100](#2100), [#2105](#2105), [#2106](#2106), [#2112](#2112), [#2133](#2133)), by @fengmk2 - Verify that created monorepo libraries emit declarations in CI ([#2171](#2171)), by @wan9chi ### Bundled Versions | Tool | Version | Source | | --------------- | ------- | ----------------------------------------------------------------------- | | vite | `8.1.4` | [`a477454`](vitejs/vite@a477454) | | rolldown | `1.1.5` | [`f09947a`](rolldown/rolldown@f09947a) | | tsdown | `0.22.7` | [npm](https://npmx.dev/package/tsdown/v/0.22.7) | | vitest | `4.1.10` | [npm](https://npmx.dev/package/vitest/v/4.1.10) | | oxlint | `1.73.0` | [npm](https://npmx.dev/package/oxlint/v/1.73.0) | | oxlint-tsgolint | `0.24.0` | [npm](https://npmx.dev/package/oxlint-tsgolint/v/0.24.0) | | oxfmt | `0.58.0` | [npm](https://npmx.dev/package/oxfmt/v/0.58.0) | ### Upgrade ```bash vp upgrade ``` ### New Contributors Welcome @yukinoshi and @BlankParticle. **Full Changelog**: v0.2.4...v0.2.5 --- Merging this PR will trigger the release workflow. --------- Co-authored-by: voidzero-guard[bot] <278573678+voidzero-guard[bot]@users.noreply.github.com> Co-authored-by: wan9chi <dk4rest@gmail.com>

fengmk2 approved these changes Jul 9, 2026

View reviewed changes

chatgpt-codex-connector Bot reviewed Jul 9, 2026

View reviewed changes

Comment thread crates/vite_cli_snapshots/tests/cli_snapshots/flavor.rs Outdated

liangmiQwQ marked this pull request as draft July 9, 2026 11:26

wip

99530cc

liangmiQwQ force-pushed the liang/codex/add-corepack-snap-allowlist branch from 0b5f3fd to 99530cc Compare July 9, 2026 13:06

liangmiQwQ changed the title ~~test(snapshots): add corepack to tools allowlist~~ test(snapshots): expose Vite+ managed binaries with vp env setup Jul 9, 2026

liangmiQwQ added 3 commits July 9, 2026 21:28

fix(snapshots): keep vpt on case PATH

ae40194

Merge branch 'main' into liang/codex/add-corepack-snap-allowlist

14263a1

fix(snapshots): use one current package layout

300dc4e

liangmiQwQ added 2 commits July 10, 2026 07:33

simplify

f9aabc6

Merge branch 'main' into liang/codex/add-corepack-snap-allowlist

38f4701

chatgpt-codex-connector Bot reviewed Jul 10, 2026

View reviewed changes

Comment thread packages/tools/src/migrate-snap-tests.ts

Comment thread crates/vite_cli_snapshots/tests/cli_snapshots/main.rs

allow git

ab38d1d

liangmiQwQ marked this pull request as ready for review July 10, 2026 01:21

liangmiQwQ mentioned this pull request Jul 10, 2026

Infra: refactor global snap test #2032

Closed

liangmiQwQ and others added 3 commits July 10, 2026 09:25

add corepack

0bd2951

Merge remote-tracking branch 'upstream/main' into liang/codex/add-cor…

e1e76a4

…epack-snap-allowlist # Conflicts: # crates/vite_cli_snapshots/tests/cli_snapshots/main.rs

Merge branch 'main' into liang/codex/add-corepack-snap-allowlist

f619174

fengmk2 approved these changes Jul 10, 2026

View reviewed changes

fengmk2 merged commit 3fe3f0d into voidzero-dev:main Jul 10, 2026
51 checks passed

liangmiQwQ deleted the liang/codex/add-corepack-snap-allowlist branch July 10, 2026 03:15

This was referenced Jul 10, 2026

test(snapshots): migrate npm-global-* cases to the PTY snapshot suite #2134

Merged

Tracking: migrate legacy snap tests to the PTY snapshot suite #2116

Closed

wan9chi mentioned this pull request Jul 15, 2026

release: v0.2.5: Cleaner environments and more reliable workflows #2180

Merged

Uh oh!

Conversation

liangmiQwQ commented Jul 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify Bot commented Jul 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for viteplus-preview ready!

Uh oh!

liangmiQwQ commented Jul 9, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

liangmiQwQ commented Jul 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fengmk2 commented Jul 9, 2026

Uh oh!

liangmiQwQ commented Jul 9, 2026

Uh oh!

fengmk2 commented Jul 9, 2026

Uh oh!

liangmiQwQ commented Jul 9, 2026

Uh oh!

fengmk2 commented Jul 9, 2026

Uh oh!

liangmiQwQ commented Jul 9, 2026

Uh oh!

liangmiQwQ commented Jul 9, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

fengmk2 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

liangmiQwQ commented Jul 9, 2026 •

edited

Loading

netlify Bot commented Jul 9, 2026 •

edited

Loading

liangmiQwQ commented Jul 9, 2026 •

edited

Loading