Skip to content

[Merged by Bors] - Implement TrinoCatalog according to ADR#263

Closed
sbernauer wants to merge 29 commits into
mainfrom
feature/trino-catalog-2
Closed

[Merged by Bors] - Implement TrinoCatalog according to ADR#263
sbernauer wants to merge 29 commits into
mainfrom
feature/trino-catalog-2

Conversation

@sbernauer

@sbernauer sbernauer commented Aug 25, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Description

For #13

Review Checklist

  • Code contains useful comments
  • CRD change approved (or not applicable)
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)
  • Helm chart can be installed and deployed operator works (or not applicable)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@sbernauer sbernauer changed the title Feature/trino catalog 2 Implement TrinoCatalog according to ADR Aug 25, 2022
@sbernauer sbernauer mentioned this pull request Aug 25, 2022
Closed
6 tasks
@sbernauer
sbernauer marked this pull request as ready for review August 25, 2022 08:12
@sbernauer
sbernauer requested a review from a team August 25, 2022 08:13
maltesander
maltesander requested changes Aug 25, 2022
View reviewed changes

@maltesander maltesander left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First batch, running tests now.

Comment thread rust/crd/src/catalog.rs Outdated
Comment thread rust/crd/src/catalog.rs Outdated
Comment thread rust/operator-binary/src/catalog.rs Outdated
Comment thread rust/operator-binary/src/catalog.rs Outdated
Comment thread rust/operator-binary/src/catalog.rs Outdated
Comment thread tests/templates/kuttl/smoke/01-install-minio.yaml.j2
Comment thread tests/templates/kuttl/smoke/02-assert.yaml Outdated
Comment thread tests/templates/kuttl/smoke/04-assert.yaml Outdated
Comment thread tests/templates/kuttl/smoke/check-s3.py
Comment thread rust/operator-binary/src/controller.rs
maltesander
maltesander requested changes Aug 25, 2022
View reviewed changes

@maltesander maltesander left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the usage.adoc at Configuration & Environment Overrides the hive.properties is still mentionend. We need an extra section just for each catalog and mention the overrides there.
LGTM otherwise.

Comment thread rust/operator-binary/src/catalog.rs Outdated
@sbernauer
sbernauer requested a review from maltesander August 29, 2022 09:11
maltesander
maltesander approved these changes Aug 29, 2022
View reviewed changes

@maltesander maltesander left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sbernauer
sbernauer force-pushed the feature/trino-catalog-2 branch from f8df7f7 to cffc6a2 Compare August 29, 2022 09:36
@sbernauer

sbernauer commented Aug 29, 2022

Copy link
Copy Markdown
Member Author

Try 1: https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/trino-operator-it-custom/15/

@sbernauer
sbernauer force-pushed the feature/trino-catalog-2 branch from bfbfaac to 5b36905 Compare August 29, 2022 13:33
@sbernauer
sbernauer force-pushed the feature/trino-catalog-2 branch from 5152b79 to 47ce864 Compare August 29, 2022 13:35
@sbernauer

sbernauer commented Aug 30, 2022

Copy link
Copy Markdown
Member Author

Test https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/trino-operator-it-custom/16/ suceeded
Triggered another one https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/trino-operator-it-custom/17/

@sbernauer

sbernauer commented Aug 30, 2022

Copy link
Copy Markdown
Member Author

2 passes in a row. That's a good sign :)

@sbernauer
sbernauer requested a review from maltesander August 30, 2022 06:03
maltesander
maltesander approved these changes Aug 30, 2022
View reviewed changes

@maltesander maltesander left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sbernauer

sbernauer commented Aug 30, 2022

Copy link
Copy Markdown
Member Author

bors r+

bors Bot pushed a commit that referenced this pull request Aug 30, 2022
@sbernauer
Implement TrinoCatalog according to ADR (#263)
a9b70a6 
# Description

For #13
@bors

bors Bot commented Aug 30, 2022

Copy link
Copy Markdown
Contributor

Pull request successfully merged into main.

Build succeeded:

@bors bors Bot changed the title Implement TrinoCatalog according to ADR [Merged by Bors] - Implement TrinoCatalog according to ADR Aug 30, 2022
@bors bors Bot closed this Aug 30, 2022
@bors
bors Bot deleted the feature/trino-catalog-2 branch August 30, 2022 06:44
@maltesander maltesander mentioned this pull request Aug 30, 2022
Closed
5 tasks
@soenkeliebau soenkeliebau mentioned this pull request Sep 6, 2022
Closed
2 tasks
@soenkeliebau

soenkeliebau commented Sep 6, 2022

Copy link
Copy Markdown
Member

Happy overall, I just opened #274 as a follow up, as I think we should add a bit more explanation around the fundamental concepts to the doc.

@soenkeliebau soenkeliebau removed their assignment Sep 6, 2022
@sbernauer sbernauer mentioned this pull request Sep 8, 2022
Closed
bors Bot pushed a commit that referenced this pull request Sep 8, 2022
@sbernauer
Release 0.6.0 (#278)
08fa672 
Proposing a release that's part of 22.09 to combine the TrinoCatalog feature (#263) with a fix that's a breaking change (#277).

By including trino-operator 0.6.0 in 22.09 we don't have a breaking change between platform releases.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maltesander maltesander maltesander approved these changes

Assignees

No one assigned

Labels

release/22-9.0

Projects

Stackable Engineering
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sbernauer @soenkeliebau @maltesander @lfrancke