Implement TrinoCatalog according to ADR#209
Closed
nightkr wants to merge 23 commits into
Closed
Conversation
Contributor
Author
|
There's still some work to be done cleaning this up and migrating the existing S3 support (which is currently broken). |
6 tasks
sbernauer
reviewed
Aug 2, 2022
sbernauer
force-pushed
the
feature/trino-catalog
branch
from
August 3, 2022 13:42
7b67227 to
051746f
Compare
sbernauer
marked this pull request as ready for review
August 3, 2022 14:14
Contributor
|
is this for #13 ? |
Member
|
Yeah, my thought process was to do them at once, yes. |
Member
|
Superseded by #263 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
See https://docs.stackable.tech/home/contributor/adr/ADR019-trino_catalog_definitions.html and https://docs.stackable.tech/home/contributor/adr/ADR020-trino_catalog_usage.html
Review Checklist
Once the review is done, comment
bors r+(orbors merge) to merge. Further information