[Merged by Bors] - TrinoClusters must specify a catalogLabelSelector#277
Closed
sbernauer wants to merge 7 commits into
Closed
[Merged by Bors] - TrinoClusters must specify a catalogLabelSelector#277sbernauer wants to merge 7 commits into
sbernauer wants to merge 7 commits into
Conversation
maltesander
reviewed
Sep 7, 2022
maltesander
left a comment
maltesander
left a comment
Member
There was a problem hiding this comment.
LGTM. But breaking change without discussion?
sbernauer
changed the title
Member
Author
|
We discussed this in Slack and Lars, Sönke and Teo approved (send you the link) |
Member
Author
maltesander
approved these changes
Sep 8, 2022
maltesander
left a comment
maltesander
left a comment
Member
There was a problem hiding this comment.
LGTM but please wait for the tests!
13 tasks
Member
Author
|
Tests succeeded |
Member
Author
|
bors r+ |
bors Bot
pushed a commit
that referenced
this pull request
Sep 8, 2022
# Description
During bumping the demos to the 22.09 i noticed that the following spec from the Trino tests and docs is invalid
```
apiVersion: trino.stackable.tech/v1alpha1
kind: TrinoCluster
metadata:
name: simple-trino
spec:
version: 387-stackable0.1.0
catalogLabelSelector:
trino: simple-trino
```
instead it should be
```
# ...
catalogLabelSelector:
matchLabels:
trino: simple-trino
```
Nobody noticed this, as the field `catalogLabelSelector` is optional. If it is not provided, the (nonexistent) Labelselector will match every TrinoCatalog withing the same Namespace and the test passed anyway.
This behavior sounds unsafe/unwanted so i suggest to make it explicit by requiring a Labelselector.
Although this change is technically breaking, the `TrinoCatalog` feature change has been release for a single day now, so impact should be pretty minimal. It would be greatif we could include this Change in 22.09, so that we reduce the number of breaking changes between Platform releases
## Review Checklist
- [x] Code contains useful comments
- [x] CRD change approved (or not applicable)
- [x] (Integration-)Test cases added (or not applicable)
- [x] Documentation added (or not applicable)
- [x] Changelog updated (or not applicable)
- [x] Cargo.toml only contains references to git tags (not specific commits or branches)
- [x] Helm chart can be installed and deployed operator works (or not applicable)
Once the review is done, comment `bors r+` (or `bors merge`) to merge. [Further information](https://bors.tech/documentation/getting-started/#reviewing-pull-requests)
Contributor
|
Pull request successfully merged into main. Build succeeded: |
bors
Bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
During bumping the demos to the 22.09 i noticed that the following spec from the Trino tests and docs is invalid
instead it should be
Nobody noticed this, as the field
catalogLabelSelectoris optional. If it is not provided, the (nonexistent) Labelselector will match every TrinoCatalog withing the same Namespace and the test passed anyway.This behavior sounds unsafe/unwanted so i suggest to make it explicit by requiring a Labelselector.
Although this change is technically breaking, the
TrinoCatalogfeature change has been release for a single day now, so impact should be pretty minimal. It would be greatif we could include this Change in 22.09, so that we reduce the number of breaking changes between Platform releasesReview Checklist
Once the review is done, comment
bors r+(orbors merge) to merge. Further information