[FEAT] Add new 'News' page#228
Merged
Merged
Conversation
csouchet
added
enhancement
|
♻️ PR Preview e03eae9 has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
8 tasks
csouchet
force-pushed
the
187-Add_new_News_page
branch
3 times, most recently
from
November 19, 2021 17:25
30f5ebe to
1822a42
Compare
csouchet
force-pushed
the
187-Add_new_News_page
branch
from
November 22, 2021 09:56
1822a42 to
2a218d6
Compare
csouchet
force-pushed
the
187-Add_new_News_page
branch
from
November 22, 2021 14:29
2a218d6 to
e03eae9
Compare
csouchet
removed
the
depends on another PR ⚠️
csouchet
marked this pull request as ready for review
November 22, 2021 14:30
tbouffard
approved these changes
Nov 22, 2021
tbouffard
left a comment
tbouffard
left a comment
Member
There was a problem hiding this comment.
LGTM
I have tested the page content and navigation from/to the new 'news' page.
Thanks for making the code reusable between the 'blog' and 'news' page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Covers #187
Accessible from : http://localhost:8000/news and https://process-analytics-process-analytics-dev-site_preview-pr-228.surge.sh/news