[FEAT] Don't display all the posts in the 'News' section of the 'Home' page#229
Merged
Merged
Conversation
csouchet
added
enhancement
|
♻️ PR Preview a0dbf1b has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
csouchet
changed the title
8 tasks
csouchet
force-pushed
the
187-Don_t_display_all_the_news_in_the_home_page
branch
2 times, most recently
from
November 22, 2021 14:29
f7a270c to
e8444b2
Compare
csouchet
force-pushed
the
187-Don_t_display_all_the_news_in_the_home_page
branch
from
November 22, 2021 14:44
e8444b2 to
58c2191
Compare
csouchet
removed
the
depends on another PR ⚠️
csouchet
marked this pull request as ready for review
November 22, 2021 14:45
tbouffard
approved these changes
Nov 22, 2021
tbouffard
left a comment
tbouffard
left a comment
Member
There was a problem hiding this comment.
LGTM, a minor comment that doesn't block the merge
| containerTitle={SECTION.news} | ||
| Background={Background} | ||
| posts={newsContent.news} | ||
| pageId="news" |
Member
There was a problem hiding this comment.
However, I don't think it's worth taking time to hide the 'More' button we we have less than 7 elements in the list. We should put energy on writing more news to drop the need for hiding the button 😈
Feel free to merge without changing anything here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Covers #187