Skip to content

increase gometalinter deadline from 30s to 120s#43

Closed
gdevillele wants to merge 1 commit into
docker:masterfrom
gdevillele:pr-update-lint-dockerfile
Closed

increase gometalinter deadline from 30s to 120s#43
gdevillele wants to merge 1 commit into
docker:masterfrom
gdevillele:pr-update-lint-dockerfile

Conversation

@gdevillele

Copy link
Copy Markdown
Contributor

so it doesn’t timeout when running in Docker for Mac

$ make -f docker.Makefile lint

was failing on my Mac.

Signed-off-by: Gaetan de Villele gdevillele@gmail.com

so it doesn’t timeout when running in Docker for Mac

Signed-off-by: Gaetan de Villele <gdevillele@gmail.com>
@gdevillele gdevillele requested a review from dnephin May 8, 2017 18:19
@dnephin

dnephin commented May 8, 2017

Copy link
Copy Markdown
Contributor

The deadline is already in the config, why do we need it twice?

@dnephin

dnephin commented May 8, 2017

Copy link
Copy Markdown
Contributor

Oh wait, that PR hasn't merged yet. Can I rebase #27 instead of this?

Or maybe just add "Deadline": "2m", to the config?

@gdevillele

Copy link
Copy Markdown
Contributor Author

Sorry, I did not know #27 was setting the deadline to 2m.
Let's keep #27 and close this PR.

@gdevillele gdevillele closed this May 8, 2017
nobiit pushed a commit to nobidev/docker-cli that referenced this pull request Nov 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants