More linters and better circle-ci config#27
Merged
Conversation
dnephin
force-pushed
the
more-linters
branch
4 times, most recently
from
8ff879a to
a004407
Compare
dnephin
force-pushed
the
more-linters
branch
2 times, most recently
from
30922c6 to
cb86678
Compare
vdemeester
approved these changes
May 4, 2017
vdemeester
left a comment
vdemeester
left a comment
Collaborator
There was a problem hiding this comment.
Overall LGTM 👼
We might want to wait for #11 to get merged to have less conflicts ?
|
|
||
| // NewContainerCommand returns a cobra command for `container` subcommands | ||
| // nolint: interfacer | ||
| func NewContainerCommand(dockerCli *command.DockerCli) *cobra.Command { |
Contributor
Author
There was a problem hiding this comment.
There are some auth methods that don't exist on the interface yet. And if I change this I have to change everything in the container/ package, so I wanted to delay that change.
Most // nolint should be considered the equivalent of a // TODO: fix this
| // PushTrustedReference pushes a canonical reference to the trust server. | ||
| // nolint: gocyclo | ||
| func PushTrustedReference(cli *command.DockerCli, repoInfo *registry.RepositoryInfo, ref reference.Named, authConfig types.AuthConfig, in io.Reader) error { | ||
| func PushTrustedReference(streams command.Streams, repoInfo *registry.RepositoryInfo, ref reference.Named, authConfig types.AuthConfig, in io.Reader) error { |
|
|
||
| // NewNetworkCommand returns a cobra command for `network` subcommands | ||
| // nolint: interfacer | ||
| func NewNetworkCommand(dockerCli *command.DockerCli) *cobra.Command { |
|
|
||
| // NewPluginCommand returns a cobra command for `plugin` subcommands | ||
| // nolint: interfacer | ||
| func NewPluginCommand(dockerCli *command.DockerCli) *cobra.Command { |
|
|
||
| // NewSecretCommand returns a cobra command for `secret` subcommands | ||
| // nolint: interfacer | ||
| func NewSecretCommand(dockerCli *command.DockerCli) *cobra.Command { |
Contributor
Author
|
Sure, I'm fine to wait |
Signed-off-by: Daniel Nephin <dnephin@docker.com>
Signed-off-by: Daniel Nephin <dnephin@docker.com>
Signed-off-by: Daniel Nephin <dnephin@docker.com>
Signed-off-by: Daniel Nephin <dnephin@docker.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the last 2 linters.
lllchecks line length. 200 is rather long, but it's a startinterfacerchecks for when an unnecessarily large interface is used.I've also updated the circleci config to run each of the steps in parallel. This cuts down the build time to just the slowest step, which is currently
cross. With #26 cross is going to get even slower.With this change we can also download binaries for each build: https://circleci.com/gh/docker/cli/51#artifacts/containers/1