Skip to content

fix(table-core): preserve clicked row in single-select mode #6429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KevinVandy merged 1 commit into from
Jul 17, 2026
+17 −2
Merged

fix(table-core): preserve clicked row in single-select mode #6429

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/table-core/src/features/row-selection/rowSelectionFeature.utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -487,7 +487,8 @@ export function table_getToggleAllPageRowsSelectedHandler<
* Selects or deselects this row.
*
* Omitting `value` toggles the row. Child rows are selected recursively unless
* `opts.selectChildren` is `false` or sub-row selection is disabled.
* `opts.selectChildren` is `false`, sub-row selection is disabled, or the row
* only supports single selection.
*
* @example
* ```ts
Expand All @@ -513,7 +514,7 @@ export function row_toggleSelected<
rowSelection,
row.id,
value,
opts?.selectChildren ?? true,
(opts?.selectChildren ?? true) && row_getCanMultiSelect(row),
row.table,
)

Expand Down
14 changes: 14 additions & 0 deletions packages/table-core/tests/unit/features/row-selection/rowSelectionFeature.utils.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,6 +353,20 @@ describe('row_toggleSelected', () => {
'0': true,
})
})

it('should select the clicked parent row when multi-select is disabled', () => {
const onRowSelectionChange = vi.fn()
const table = makeTable(
{ onRowSelectionChange, enableMultiRowSelection: false },
[3, 2],
)

row_toggleSelected(table.getRow('0'), true)

expect(getUpdaterResult(onRowSelectionChange, {})).toEqual({
'0': true,
})
})
})

describe('row_getIsSomeSelected / row_getIsAllSubRowsSelected', () => {
Expand Down
Loading