fix(table-core): preserve clicked row in single-select mode#6429
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit d85c069
☁️ Nx Cloud last updated this comment at |
1 participant
Summary
Root cause
Selecting a parent recursively selected its descendants. With
enableMultiRowSelection: false, each recursive descendant cleared the preceding selection, so the final leaf row replaced the parent that the user clicked.Impact
Single-select tables now preserve the clicked parent row instead of selecting its final descendant. Existing multi-select sub-row behavior is unchanged.
Validation
pnpm dlx --package=vitest@4.1.9 vitest run packages/table-core/tests/unit/features/row-selection packages/table-core/tests/implementation/features/row-selection(91 tests passed)git diff --checkCloses #4299
Summary by CodeRabbit