[7/N] feat(gateway): add request history lookups#346
Open
albertywu wants to merge 1 commit into
Open
Conversation
This was referenced Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
feat(gateway): add request history lookups
Test Plan
✅
make fmt && make build && make test && make e2e-testLocal full-stack gRPC verification
2026-07-13245a0cbb94623f7a57e44d295f52e53657d3b13dmake local-submitqueue-start.grpcurlusingapi/submitqueue/gateway/proto/gateway.proto.erroras a duplicate of the in-flight request. This exercises successful and error projections.StatusByIDlastError.StatusByChangeIDListpageSize: 1.HistoryByIDlandedanderror.HistoryByChangeIDlastError.Exact gRPC requests and stdout
Setup: Land request 1RPC:
uber.submitqueue.gateway.SubmitQueueGateway/LandRequest:
{"queue":"e2e-test-queue","change":{"uris":["github://uber/grpc-verification/pull/789/0123456789abcdef0123456789abcdef01234567"]},"strategy":"REBASE"}STDOUT:
{ "sqid": "e2e-test-queue/1" }Setup: Land request 2 with the same pinned changeRPC:
uber.submitqueue.gateway.SubmitQueueGateway/LandRequest:
{"queue":"e2e-test-queue","change":{"uris":["github://uber/grpc-verification/pull/789/0123456789abcdef0123456789abcdef01234567"]},"strategy":"REBASE"}STDOUT:
{ "sqid": "e2e-test-queue/2" }StatusByID: successful requestRPC:
uber.submitqueue.gateway.SubmitQueueGateway/StatusByIDRequest:
{"sqid":"e2e-test-queue/1"}STDOUT:
{ "request": { "sqid": "e2e-test-queue/1", "queue": "e2e-test-queue", "changeUris": [ "github://uber/grpc-verification/pull/789/0123456789abcdef0123456789abcdef01234567" ], "receivedAtMs": "1783981410120", "status": "landed", "metadata": { "batch_id": "e2e-test-queue/batch/1" } } }StatusByID: duplicate requestRPC:
uber.submitqueue.gateway.SubmitQueueGateway/StatusByIDRequest:
{"sqid":"e2e-test-queue/2"}STDOUT:
{ "request": { "sqid": "e2e-test-queue/2", "queue": "e2e-test-queue", "changeUris": [ "github://uber/grpc-verification/pull/789/0123456789abcdef0123456789abcdef01234567" ], "receivedAtMs": "1783981410176", "status": "error", "lastError": "request e2e-test-queue/2 is a duplicate of in-flight request e2e-test-queue/1" } }StatusByChangeIDRPC:
uber.submitqueue.gateway.SubmitQueueGateway/StatusByChangeIDRequest:
{"changeId":"github://uber/grpc-verification/pull/789/0123456789abcdef0123456789abcdef01234567"}STDOUT:
{ "requests": [ { "sqid": "e2e-test-queue/2", "queue": "e2e-test-queue", "changeUris": [ "github://uber/grpc-verification/pull/789/0123456789abcdef0123456789abcdef01234567" ], "receivedAtMs": "1783981410176", "status": "error", "lastError": "request e2e-test-queue/2 is a duplicate of in-flight request e2e-test-queue/1" }, { "sqid": "e2e-test-queue/1", "queue": "e2e-test-queue", "changeUris": [ "github://uber/grpc-verification/pull/789/0123456789abcdef0123456789abcdef01234567" ], "receivedAtMs": "1783981410120", "status": "landed", "metadata": { "batch_id": "e2e-test-queue/batch/1" } } ] }List: first pageRPC:
uber.submitqueue.gateway.SubmitQueueGateway/ListRequest:
{"queue":"e2e-test-queue","receivedAtOrAfterMs":1783981410120,"receivedBeforeMs":1783981410177,"pageSize":1}STDOUT:
{ "requests": [ { "sqid": "e2e-test-queue/2", "queue": "e2e-test-queue", "changeUris": [ "github://uber/grpc-verification/pull/789/0123456789abcdef0123456789abcdef01234567" ], "receivedAtMs": "1783981410176", "status": "error", "lastError": "request e2e-test-queue/2 is a duplicate of in-flight request e2e-test-queue/1" } ], "nextPageToken": "bGFzdF9yZWNlaXZlZF9hdF9tcz0xNzgzOTgxNDEwMTc2Jmxhc3RfcmVxdWVzdF9pZD1lMmUtdGVzdC1xdWV1ZSUyRjImcXVldWU9ZTJlLXRlc3QtcXVldWUmcmVjZWl2ZWRfYXRfb3JfYWZ0ZXJfbXM9MTc4Mzk4MTQxMDEyMCZyZWNlaXZlZF9iZWZvcmVfbXM9MTc4Mzk4MTQxMDE3Nw" }List: second pageRPC:
uber.submitqueue.gateway.SubmitQueueGateway/ListRequest:
{"queue":"e2e-test-queue","receivedAtOrAfterMs":1783981410120,"receivedBeforeMs":1783981410177,"pageSize":1,"pageToken":"bGFzdF9yZWNlaXZlZF9hdF9tcz0xNzgzOTgxNDEwMTc2Jmxhc3RfcmVxdWVzdF9pZD1lMmUtdGVzdC1xdWV1ZSUyRjImcXVldWU9ZTJlLXRlc3QtcXVldWUmcmVjZWl2ZWRfYXRfb3JfYWZ0ZXJfbXM9MTc4Mzk4MTQxMDEyMCZyZWNlaXZlZF9iZWZvcmVfbXM9MTc4Mzk4MTQxMDE3Nw"}STDOUT:
{ "requests": [ { "sqid": "e2e-test-queue/1", "queue": "e2e-test-queue", "changeUris": [ "github://uber/grpc-verification/pull/789/0123456789abcdef0123456789abcdef01234567" ], "receivedAtMs": "1783981410120", "status": "landed", "metadata": { "batch_id": "e2e-test-queue/batch/1" } } ] }HistoryByID: successful requestRPC:
uber.submitqueue.gateway.SubmitQueueGateway/HistoryByIDRequest:
{"sqid":"e2e-test-queue/1"}STDOUT:
{ "events": [ { "timestampMs": "1783981410120", "status": "accepted" }, { "timestampMs": "1783981410282", "status": "started" }, { "timestampMs": "1783981410900", "status": "batched", "metadata": { "batch_id": "e2e-test-queue/batch/1" } }, { "timestampMs": "1783981411102", "status": "scored", "metadata": { "batch_id": "e2e-test-queue/batch/1", "score": "0.7000" } }, { "timestampMs": "1783981412404", "status": "landed", "metadata": { "batch_id": "e2e-test-queue/batch/1" } } ] }HistoryByID: duplicate requestRPC:
uber.submitqueue.gateway.SubmitQueueGateway/HistoryByIDRequest:
{"sqid":"e2e-test-queue/2"}STDOUT:
{ "events": [ { "timestampMs": "1783981410176", "status": "accepted" }, { "timestampMs": "1783981410291", "status": "started" }, { "timestampMs": "1783981410575", "status": "error", "lastError": "request e2e-test-queue/2 is a duplicate of in-flight request e2e-test-queue/1" } ] }HistoryByChangeIDRPC:
uber.submitqueue.gateway.SubmitQueueGateway/HistoryByChangeIDRequest:
{"changeId":"github://uber/grpc-verification/pull/789/0123456789abcdef0123456789abcdef01234567"}STDOUT:
{ "histories": [ { "sqid": "e2e-test-queue/1", "events": [ { "timestampMs": "1783981410120", "status": "accepted" }, { "timestampMs": "1783981410282", "status": "started" }, { "timestampMs": "1783981410900", "status": "batched", "metadata": { "batch_id": "e2e-test-queue/batch/1" } }, { "timestampMs": "1783981411102", "status": "scored", "metadata": { "batch_id": "e2e-test-queue/batch/1", "score": "0.7000" } }, { "timestampMs": "1783981412404", "status": "landed", "metadata": { "batch_id": "e2e-test-queue/batch/1" } } ] }, { "sqid": "e2e-test-queue/2", "events": [ { "timestampMs": "1783981410176", "status": "accepted" }, { "timestampMs": "1783981410291", "status": "started" }, { "timestampMs": "1783981410575", "status": "error", "lastError": "request e2e-test-queue/2 is a duplicate of in-flight request e2e-test-queue/1" } ] } ] }Stack