feat(stovepipe): coalesce backlog in process controller#324
Merged
Conversation
mnoah1
changed the title
mnoah1
force-pushed
the
mnoah1/stovepipe-process-coalesce
branch
from
65c5fd6 to
0bb81c6
Compare
mnoah1
changed the title
mnoah1
changed the title
mnoah1
force-pushed
the
mnoah1/stovepipe-ingest-queue-wiring
branch
from
6a281c4 to
b27d20c
Compare
mnoah1
force-pushed
the
mnoah1/stovepipe-process-coalesce
branch
from
0bb81c6 to
686ed39
Compare
mnoah1
changed the title
mnoah1
force-pushed
the
mnoah1/stovepipe-ingest-queue-wiring
branch
from
fee8ec1 to
5f7ab76
Compare
mnoah1
force-pushed
the
mnoah1/stovepipe-process-coalesce
branch
from
1a66cd1 to
ee5ac0c
Compare
mnoah1
force-pushed
the
mnoah1/stovepipe-ingest-queue-wiring
branch
from
5f7ab76 to
1cb5649
Compare
mnoah1
force-pushed
the
mnoah1/stovepipe-process-coalesce
branch
from
ee5ac0c to
c1ee23a
Compare
behinddwalls
force-pushed
the
mnoah1/stovepipe-process-coalesce
branch
from
c1ee23a to
7003035
Compare
behinddwalls
changed the base branch from
mnoah1/stovepipe-ingest-queue-wiring
to
main
behinddwalls
approved these changes
Jul 13, 2026
behinddwalls
left a comment
behinddwalls
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed the coalesce logic against the ingest-side invariants (pointer stamped before publish, queue row ensured before publish) — the supersede path and retryability calls all check out. Left a few minor inline suggestions, nothing blocking.
One non-inline note: unit coverage for the new transition is good; test/integration/stovepipe still only exercises ingest. A follow-up that ingests two successive heads through the real stack and asserts the older ends superseded would cover the CAS path against real MySQL — fine as a separate PR once the fake SourceControl can report successive heads.
Compare accepted requests against queue.latest_request_id and mark older heads superseded. Latest heads remain accepted until admit lands in a follow-up PR.
Add processing republish TODO, warn on unexpected states, broaden storage_errors and superseded metrics, and harden coalesce unit tests.
mnoah1
force-pushed
the
mnoah1/stovepipe-process-coalesce
branch
from
7003035 to
2b2eb79
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This PR begins implementing core logic of the Process controller to supersede older requests as new ones come in.
https://github.com/uber/submitqueue/blob/main/doc/rfc/stovepipe/steps/process.md#process-algorithm
acceptedrequests get compared against the queue's latest request ID valuesuperseded/processing→ ack no-opWhy
Implementing https://github.com/uber/submitqueue/blob/main/doc/rfc/stovepipe/steps/process.md step. Building out logic to accept incoming requests and narrow down builds to only the latest head.
Test plan
//stovepipe/controller/process:go_default_test//stovepipe/controller:go_default_test//test/integration/stovepipe:go_default_test