[pull] master from php:master#1087
Merged
Merged
Conversation
SOAP encoding errors now report the affected type or failing operation in the error message instead of the generic "Encoding: Violation of encoding rules" message. Code that compares the exact message may need to be updated.
So that when the outputs are fixed the changes can be confirmed in tests
Given that there is not an unchecked version of `smart_str_append_printf()`, to avoid compiler warnings from using `%S` to format `zend_string` pointers (which the smart string printing machinery supports, but printf does not support) in a few places the format specifier is declared in a variable rather than being specified directly in the `smart_str_append_printf()` call.
* PHP-8.4: NEWS GH-22681: avoid truncation on null bytes in `Reflection*::__toString()` Add regression tests for `Reflection*::__toString()` with null bytes
* PHP-8.5: NEWS GH-22681: avoid truncation on null bytes in `Reflection*::__toString()` Add regression tests for `Reflection*::__toString()` with null bytes
The ext/odbc and pdo_odbc regression tests connect through a real ODBC driver (Driver=SQLite3), which was never installed, so they skipped on every lane. libsqliteodbc registers the SQLite3 driver and supports Database=:memory:, so the tests run without a database server. Alpine has no such package, so those lanes keep skipping. Closes GH-22686
* PHP-8.4: Install the SQLite ODBC driver in CI
* PHP-8.5: Install the SQLite ODBC driver in CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )