Skip to content

fix(webapp): revert: survive asset hash rotation across rolling deploys 2aa6420#4277

Open
carderne wants to merge 1 commit into
mainfrom
fix/revert-2aa6420
Open

fix(webapp): revert: survive asset hash rotation across rolling deploys 2aa6420#4277
carderne wants to merge 1 commit into
mainfrom
fix/revert-2aa6420

Conversation

@carderne

Copy link
Copy Markdown
Collaborator

This reverts commit 2aa6420.

Reverts #4260

Caused issues with webapp dashboard during rollout

Reverting pending full fix

@changeset-bot

changeset-bot Bot commented Jul 17, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 1b5b943

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@carderne
carderne marked this pull request as ready for review July 17, 2026 09:30
@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

Removed the StaleAssetRecovery component and its root-document integrations. Removed server support for the X-Build-Id header and /build-version endpoint, and stopped applying default Cache-Control: no-cache headers to HTML responses. Updated server-app release-note guidance with placeholder wording, allowed area and type values, and package-change rules.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description explains the revert but lacks required template sections like Testing, Changelog details, and checklist completion. Add Testing section describing how the revert was verified, expand Changelog with brief summary of changes, and mark checklist items as completed or incomplete.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly summarizes the main change: reverting a specific commit related to stale asset recovery.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/revert-2aa6420

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@carderne carderne changed the title Revert "fix(webapp): survive asset hash rotation across rolling deploys (#4260)" fix(webapp): revert: survive asset hash rotation across rolling deploys 2aa6420 Jul 17, 2026

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

Open in Devin Review

Comment thread .server-changes/stale-deploy-asset-recovery.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant