Improve SANO Sample#327
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 55367e0f8c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| env = await WorkflowEnvironment.start_local( | ||
| dev_server_download_version="v1.7.3-standalone-nexus-operations", | ||
| dev_server_extra_args=[ | ||
| "--dynamic-config-value", | ||
| "frontend.enableExecuteMultiOperation=true", | ||
| "--dynamic-config-value", | ||
| "system.enableEagerWorkflowStart=true", | ||
| "--dynamic-config-value", | ||
| "nexusoperation.enableStandalone=true", | ||
| "--dynamic-config-value", | ||
| "history.enableChasmCallbacks=true", | ||
| ], | ||
| dev_server_download_version="v1.7.4-standalone-nexus-operations", | ||
| ) |
There was a problem hiding this comment.
Starting the local test server with only the download version drops the dynamic config values that enabled the pre-release standalone Nexus paths. The default poe test run uses this fixture for tests/nexus_standalone_operations/nexus_standalone_operations_test.py, which still executes and counts standalone Nexus operations; with nexusoperation.enableStandalone/CHASM callbacks not passed via the repeatable --dynamic-config-value start-dev flag, those RPCs are rejected by the v1.7.x standalone server. Please keep the SANO dev_server_extra_args when bumping to v1.7.4.
Useful? React with 👍 / 👎.
2 participants
What was changed
Improve SANO Sample
Why?
Checklist
Closes
How was this tested: