fix(string-os.org): include @cloudflare/workers-types so root typecheck passes#52
Merged
Merged
Conversation
…sses functions/_middleware.ts (CF Pages middleware) uses PagesFunction, EventContext, and AnalyticsEngineDataset, but the app tsconfig never loaded @cloudflare/workers-types (already a devDependency), so root 'pnpm typecheck' failed on clean main. Types-only change. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Deploying string with
|
| Latest commit: |
545d33f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d7eb7224.string-bm6.pages.dev |
| Branch Preview URL: | https://nova-fix-string-os-org-typec.string-bm6.pages.dev |
Deploying docs-string with
|
| Latest commit: |
545d33f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2080021a.docs-string.pages.dev |
| Branch Preview URL: | https://nova-fix-string-os-org-typec.docs-string.pages.dev |
…dleware Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
Author
|
Follow-up commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root
pnpm typecheckfailed on clean main:apps/string-os.org/functions/_middleware.ts(Cloudflare Pages middleware from the CF migration) usesPagesFunction/EventContext/AnalyticsEngineDataset, but the app tsconfig never loaded@cloudflare/workers-types— the package was already in devDependencies, just not incompilerOptions.types.Types-only change as requested. Verified:
npx tsc --noEmitin the app passes,npx astro buildstill builds, and rootpnpm typechecknow passes across all packages.Housekeeping follow-up from the #47 slice work. Reviewer: Leo.
🤖 Generated with Claude Code