feat(send-slack-notification): Include provenance job in build status#118
Merged
Conversation
NickLarsenNZ
approved these changes
Jul 9, 2026
NickLarsenNZ
left a comment
NickLarsenNZ
left a comment
Member
There was a problem hiding this comment.
LGTM
We do have a smoke test, but I'm unsure if we need to specify the argument there: https://github.com/stackabletech/actions/blob/main/.github/workflows/smoke-build.yaml
NickLarsenNZ
moved this from Development: Waiting for Review
to Development: In Review
in Stackable Engineering
NickLarsenNZ
moved this from Development: In Review
to Development: Done
in Stackable Engineering
Member
|
We should definitely test the new input as part of our smoke build. Ideally with a real result by running the SLSA provenance generation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The container-image-build Slack notification decided success/failure from only three job results: build, publish manifests, and publish helm chart. The SLSA provenance generation job was not considered.
Needs a new release plus rollout in
docker-imagesto fix the problem.