Skip to content

improvement(hubspot): align tools with API docs and expand coverage with delete, list membership, and search tools#5635

Merged
waleedlatif1 merged 1 commit into
stagingfrom
hubspot-validation-coverage
Jul 13, 2026
Merged

improvement(hubspot): align tools with API docs and expand coverage with delete, list membership, and search tools#5635
waleedlatif1 merged 1 commit into
stagingfrom
hubspot-validation-coverage

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Full validation pass of the HubSpot integration (50 tools + block) against HubSpot's current API docs
  • Fixed a broken endpoint: list_marketing_events used /marketing/marketing-events/v3 (404s) instead of /marketing/v3/marketing-events
  • Corrected search limit docs (CRM search max is 200, not 100), typed paging as HubSpotPaging | null to match runtime, fixed company param types carrying a stray required contactId, URL-encoded idProperty in update tools
  • Block: marked propertiesToSet required (every mapped tool requires it), removed an as any cast masking type checking on outputs
  • Added 12 new tools on already-granted scopes (no OAuth scope changes): list memberships (add/remove/get — makes create_list actually useful), delete/archive for contacts, companies, deals, tickets, line items, association delete + association labels read, and search for line items and quotes
  • Wired all new operations through the block (dropdown, conditions, tool map, inputs/outputs) and registries

Type of Change

  • Improvement

Testing

Typecheck clean, lint clean, registry tests pass (80/80), check:api-validation passes. Verified no scopes were added or changed in lib/oauth/oauth.ts.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

…ith delete, list membership, and search tools
@cursor

cursor Bot commented Jul 13, 2026

Copy link
Copy Markdown

PR Summary

Medium Risk
New delete/archive and list membership tools can mutate live CRM data in workflows; scope is integration-only with existing OAuth and follows established HubSpot tool patterns.

Overview
Expands the HubSpot block and tool layer after an API-doc validation pass: 12 new operations (archive/delete for contacts, companies, deals, tickets, and line items; association delete and association labels; list member get/add/remove; search for line items and quotes), all wired through the block dropdown, conditions, tool map, inputs/outputs, tools/registry, and exports.

Fixes include the marketing-events list URL (/marketing/v3/marketing-events), CRM search limit documentation (max 200), consistent paging: null when absent, idProperty query encoding on contact/company updates, company update param types without a stray contactId, and propertiesToSet marked required on create/update flows. Block outputs drop an as any cast; a maintain-static-list skill documents list sync workflows.

Reviewed by Cursor Bugbot for commit 10028ec. Configure here.

@greptile-apps

greptile-apps Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR expands and cleans up the HubSpot integration. The main changes are:

  • Added delete/archive tools for several CRM object types.
  • Added list membership add, remove, and read tools.
  • Added association deletion and association label lookup.
  • Added line item and quote search tools.
  • Updated HubSpot block wiring, registry entries, paging types, and endpoint details.

Confidence Score: 5/5

This looks safe to merge.

  • No blocking issues found in the changed code.
  • The new tool IDs, block mappings, registry entries, and response shapes line up with the surrounding HubSpot tool patterns.

Important Files Changed

Filename Overview
apps/sim/blocks/blocks/hubspot.ts Adds the new HubSpot operations to the block UI, parameter conditions, tool selection, and outputs.
apps/sim/tools/hubspot/add_list_memberships.ts Adds a HubSpot list membership add tool with string and array record ID parsing.
apps/sim/tools/hubspot/remove_list_memberships.ts Adds the matching HubSpot list membership removal tool.
apps/sim/tools/hubspot/get_list_memberships.ts Adds paginated HubSpot list membership retrieval.
apps/sim/tools/hubspot/delete_association.ts Adds association deletion between two HubSpot records.
apps/sim/tools/hubspot/get_association_labels.ts Adds association label lookup for HubSpot object type pairs.
apps/sim/tools/hubspot/search_line_items.ts Adds CRM search support for line items.
apps/sim/tools/hubspot/search_quotes.ts Adds CRM search support for quotes.
apps/sim/tools/hubspot/index.ts Exports the new HubSpot tools from the HubSpot barrel.
apps/sim/tools/registry.ts Registers the new HubSpot tools under matching tool IDs.
apps/sim/tools/hubspot/types.ts Adds response and parameter types for the new tools and normalizes paging to null when absent.

Reviews (1): Last reviewed commit: "improvement(hubspot): align tools with A..." | Re-trigger Greptile

@waleedlatif1 waleedlatif1 merged commit 0640c0b into staging Jul 13, 2026
18 checks passed
@waleedlatif1 waleedlatif1 deleted the hubspot-validation-coverage branch July 13, 2026 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant