Deprecate the experimental EventsExecutor (backport #3192)#3206
Open
mergify[bot] wants to merge 1 commit into
Open
Deprecate the experimental EventsExecutor (backport #3192)#3206mergify[bot] wants to merge 1 commit into
mergify[bot] wants to merge 1 commit into
Conversation
Signed-off-by: Skyler Medeiros <skye@polymathrobotics.com> Signed-off-by: Janosch Machowinski <J.Machowinski@cellumation.com> Co-authored-by: Skyler Medeiros <skye@polymathrobotics.com> Co-authored-by: Janosch Machowinski <J.Machowinski@cellumation.com> (cherry picked from commit 5272750) # Conflicts: # rclcpp/test/rclcpp/executors/test_events_executor.cpp
Contributor
Author
|
Cherry-pick of 5272750 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Contributor
Author
|
Tick the box to add this pull request to the merge queue (same as
|
Collaborator
|
I don't think we allow this by the rules. Might be an exception as it is experimental ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a compile-time deprecation warning when using the experimental EventsExecutor, warning to switch to the new Callback Group Events Executor in single-threaded mode instead.
Tests which exercise the EventsExecutor have deprecation warnings disabled while it is still in the source tree.
Also replaces one usage of the old executor with the new one in
rclcpp_action/test_server.cpp.Fixes # (issue)
Is this user-facing behavior change?
Users will now get a compiler warning when using the experimental EventsExecutor in their application code
Did you use Generative AI?
Claude Opus 4.8 was used to identify spots in the codebase where the deprecation warning suppression should be introduced.
Additional Information
This ought to be backported to at least Lyrical
This is an automatic backport of pull request #3192 done by Mergify.