Move stream factory creation to node#51
Merged
Merged
Conversation
jsor
approved these changes
Nov 5, 2018
Member
|
@clue ping |
clue
approved these changes
Nov 18, 2018
ghost
deleted the
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a split of the original PR #45 (the original PR shall stay open until completely done).
This PR moves the usage of
StreamFactory::createfromAdapter::opentoNode\File::open, which makes the adapters compatible to the adapter interface. I have also gone ahead and replacedbooleanwithboolto make PHP code assistance tools happy (since technicallybooleanis seen as class).