bpo-41675: Modernize siginterrupt calls#22028
Merged
Merged
Conversation
vstinner
reviewed
Sep 2, 2020
| else { | ||
| act.sa_flags |= SA_RESTART; | ||
| } | ||
| if (sigaction(signalnum, &act, NULL)<0) { |
Member
There was a problem hiding this comment.
nitpick:
Suggested change
| if (sigaction(signalnum, &act, NULL)<0) { | |
| if (sigaction(signalnum, &act, NULL) < 0) { |
and also below: if (siginterrupt(signalnum, flag) < 0) {.
| @@ -0,0 +1,3 @@ | |||
| The implementation of :func:`signal.siginterrupt` now uses | |||
| :c:func:`sigaction` instead of the deprecated :c:func:`siginterrupt`. Patch | |||
Member
There was a problem hiding this comment.
You may mention that it's only used when sigaction() is available.
vstinner
approved these changes
Sep 2, 2020
vstinner
left a comment
vstinner
left a comment
Member
There was a problem hiding this comment.
LGTM.
The glibc deprecated siginterrupt() function has exactly the same code!
https://sourceware.org/git/?p=glibc.git;a=blob;f=sysdeps/posix/sigintr.c;h=dd8815a3bcfd1943b5a45933bfbe008fa3d6bee5;hb=HEAD
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue41675