Skip to content

gh-153622: Check PyLong_AsInt errors in legacy tracing #153623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aisk wants to merge 5 commits into
base: main
Choose a base branch
from
+13 −2
Open

gh-153622: Check PyLong_AsInt errors in legacy tracing #153623

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e5822e7
Check PyLong_AsInt errors in legacy tracing
aisk Jul 12, 2026
32a3d98
📜🤖 Added by blurb_it.
blurb-it[bot] Jul 12, 2026
34272d0
Update news entry
aisk Jul 12, 2026
fcfb2f2
Fix news entry
aisk Jul 12, 2026
fb7acd2
Remove the news entry file
aisk Jul 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions Python/legacy_tracing.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,6 +353,9 @@ sys_trace_line_func(
}
assert(PyVectorcall_NARGS(nargsf) == 2);
int line = PyLong_AsInt(args[1]);
if (line == -1 && PyErr_Occurred()) {
return NULL;
}
assert(line >= 0);
PyFrameObject *frame = PyEval_GetFrame();
if (frame == NULL) {
Expand All @@ -379,9 +382,17 @@ sys_trace_jump_func(
Py_RETURN_NONE;
}
assert(PyVectorcall_NARGS(nargsf) == 3);
int from = PyLong_AsInt(args[1])/sizeof(_Py_CODEUNIT);
int from = PyLong_AsInt(args[1]);
if (from == -1 && PyErr_Occurred()) {
return NULL;
}
from /= sizeof(_Py_CODEUNIT);
assert(from >= 0);
int to = PyLong_AsInt(args[2])/sizeof(_Py_CODEUNIT);
int to = PyLong_AsInt(args[2]);
if (to == -1 && PyErr_Occurred()) {
return NULL;
}
to /= sizeof(_Py_CODEUNIT);
assert(to >= 0);
if (to > from) {
/* Forward jump */
Expand Down
Loading