Skip to content

gh-131647: fix 'sys.path_hooks is empty' warning in test_permission_e… #131648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 1 commit into from
Mar 25, 2025
Merged

gh-131647: fix 'sys.path_hooks is empty' warning in test_permission_e… #131648

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Lib/test/test_importlib/import_/test_path.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,11 +158,15 @@ def test_deleted_cwd(self):
def test_permission_error_cwd(self):
# gh-115911: Test that an unreadable CWD does not break imports, in
# particular during early stages of interpreter startup.

def noop_hook(*args):

@vstinner vstinner Mar 25, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noop name is misleading, since the hook actually does something, raise ImportError :-) I suggest to rename the function to something like failing_path_hook.

@graingert graingert Mar 25, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with path_hooks but a noop hook is one that causes the processing to continue checking other hooks and return None if there's no others

This hook doesn't fail, eg the error is immediately caught and has no change in behavior over having no hooks other than not warning

@graingert graingert Mar 25, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy to rename it, but with "failing_path_hook" it would appear that the test was about the failing hook rather than the permission error because the new name attracts too much attention

@vstinner vstinner Mar 25, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, the name of the function doesn't matter much. I merged your PR ;-)

raise ImportError

with (
os_helper.temp_dir() as new_dir,
os_helper.save_mode(new_dir),
os_helper.change_cwd(new_dir),
util.import_state(path=['']),
util.import_state(path=[''], path_hooks=[noop_hook]),
):
# chmod() is done here (inside the 'with' block) because the order
# of teardown operations cannot be the reverse of setup order. See
Expand Down