Refactor test_capi.test_long#122113
Merged
Merged
Conversation
Share common code for tests for PyLong_As*() functions. Co-authored-by: Victor Stinner <vstinner@python.org>
serhiy-storchaka
added
tests
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 22, 2024
Share common code for tests for PyLong_As*() functions. (cherry picked from commit 69f2dc5) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com> Co-authored-by: Victor Stinner <vstinner@python.org>
|
GH-122137 is a backport of this pull request to the 3.13 branch. |
|
Sorry, @serhiy-storchaka, I could not cleanly backport this to |
Member
Author
|
Thank you, Victor. |
serhiy-storchaka
added a commit
that referenced
this pull request
Jul 23, 2024
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this pull request
Jul 23, 2024
Share common code for tests for PyLong_As*() functions. (cherry picked from commit 69f2dc5) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com> Co-authored-by: Victor Stinner <vstinner@python.org>
|
GH-122151 is a backport of this pull request to the 3.12 branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Share common code for tests for PyLong_As*() functions.
Based on test changes in #120390. The same helper is used in tests for all signed and unsigned integer types.
negative_value_erroris now an exception class, not a boolean.