gh-121039: add Floats/ComplexesAreIdenticalMixin to test.support.testcase by skirpichev · Pull Request #121071 · python/cpython

skirpichev · 2024-06-27T03:10:58Z

Issue: Add assertFloatsAreIdentical/assertComplexAreIdentical to unittest (or kwarg to assertEqual)? #121039

…t.testcase

sobolevn

Seems like a good refactoring, thanks!

sobolevn · 2024-06-27T07:55:01Z

Build failure is not related and is reported here #121065

skirpichev · 2024-06-27T09:42:51Z

There are more cases, which could be changed, some were mentioned in the issue. But I'm not sure it worth - stopping reinvent the wheel in new tests seems enough.

skirpichev · 2024-07-10T05:27:51Z

Unfortunately, #120894 was merged first. Yet one place to refactor, fixed.

serhiy-storchaka

LGTM.

serhiy-storchaka · 2024-09-08T10:41:17Z

I think that test_capi/test_getargs.py is a fair case, and pretty simple too.

Cases in test_math.py are more complex.

skirpichev · 2024-09-08T10:54:35Z

I think that test_capi/test_getargs.py is a fair case, and pretty simple too.

Yeah, added this.

Cases in test_math.py are more complex.

Some seems mechanical too (assertEqualSign helper). But I'm not sure if this worth it.

miss-islington-app · 2024-09-08T13:02:20Z

Thanks @skirpichev for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington-app · 2024-09-08T13:02:21Z

Thanks @skirpichev for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington-app · 2024-09-08T13:02:23Z

Sorry, @skirpichev and @serhiy-storchaka, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 8ef8354ef15e00d484ac2ded9442b789c24b11e0 3.13

miss-islington-app · 2024-09-08T13:02:40Z

Sorry, @skirpichev and @serhiy-storchaka, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 8ef8354ef15e00d484ac2ded9442b789c24b11e0 3.12

skirpichev · 2024-09-08T13:21:36Z

I'm working on backports.

….support.testcase (pythonGH-121071) (cherry picked from commit 8ef8354) Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>

bedevere-app · 2024-09-08T15:08:50Z

GH-123840 is a backport of this pull request to the 3.13 branch.

bedevere-app · 2024-09-08T15:15:52Z

GH-123841 is a backport of this pull request to the 3.12 branch.

…rt.testcase (GH-121071) (#123841) * [3.12] gh-121039: add Floats/ComplexesAreIdenticalMixin to test.support.testcase (GH-121071) (cherry picked from commit 8ef8354) Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>

…rt.testcase (GH-121071) (#123840) * [3.13] gh-121039: add Floats/ComplexesAreIdenticalMixin to test.support.testcase (GH-121071) (cherry picked from commit 8ef8354) Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com> * +1

pythongh-121039: add Floats/ComplexesAreIdenticalMixin to test.suppor…

d10eef8

…t.testcase

bedevere-app Bot mentioned this pull request Jun 27, 2024

Add assertFloatsAreIdentical/assertComplexAreIdentical to unittest (or kwarg to assertEqual)? #121039

Closed

bedevere-app Bot added the awaiting review label Jun 27, 2024

This comment was marked as outdated.

Sign in to view

Merge branch 'main' into num-areidentical-mixin-121039

2a2f9af

skirpichev mentioned this pull request Jun 27, 2024

gh-61103: support double complex (_Complex) type in ctypes #120894

Merged

sobolevn approved these changes Jun 27, 2024

View reviewed changes

bedevere-app Bot added awaiting merge and removed awaiting review labels Jun 27, 2024

sobolevn added the skip news label Jun 27, 2024

skirpichev added 3 commits June 28, 2024 03:47

Merge branch 'main' into num-areidentical-mixin-121039

0a1901d

Merge branch 'master' into num-areidentical-mixin-121039

b5644eb

+ adapt Lib/test/test_ctypes/test_numbers.py

4fc14b7

skirpichev mentioned this pull request Jul 12, 2024

gh-121249: Support _Complex types in the struct module #121613

Merged

skirpichev mentioned this pull request Sep 8, 2024

Issue with Round Function in Python #123811

Closed

serhiy-storchaka approved these changes Sep 8, 2024

View reviewed changes

serhiy-storchaka and others added 2 commits September 8, 2024 13:41

Merge branch 'main' into num-areidentical-mixin-121039

87d9850

address review: add mixin to test_getargs.py

01036e6

skirpichev requested a review from serhiy-storchaka September 8, 2024 10:54

serhiy-storchaka approved these changes Sep 8, 2024

View reviewed changes

serhiy-storchaka merged commit 8ef8354 into python:main Sep 8, 2024

bedevere-app Bot removed the awaiting merge label Sep 8, 2024

serhiy-storchaka added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Sep 8, 2024

miss-islington-app Bot assigned serhiy-storchaka Sep 8, 2024

serhiy-storchaka added the tests Tests in the Lib/test dir label Sep 8, 2024

skirpichev deleted the num-areidentical-mixin-121039 branch September 8, 2024 13:21

skirpichev added a commit to skirpichev/cpython that referenced this pull request Sep 8, 2024

redo on top of python#121071

42c3783

bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Sep 8, 2024

bedevere-app Bot removed the needs backport to 3.12 only security fixes label Sep 8, 2024

serhiy-storchaka removed their assignment Jul 15, 2026

Uh oh!

Uh oh!

Conversation

skirpichev commented Jun 27, 2024 • edited by bedevere-app Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

sobolevn left a comment

Choose a reason for hiding this comment

Uh oh!

sobolevn commented Jun 27, 2024

Uh oh!

skirpichev commented Jun 27, 2024

Uh oh!

skirpichev commented Jul 10, 2024

Uh oh!

serhiy-storchaka left a comment

Choose a reason for hiding this comment

Uh oh!

serhiy-storchaka commented Sep 8, 2024

Uh oh!

skirpichev commented Sep 8, 2024

Uh oh!

miss-islington-app Bot commented Sep 8, 2024

Uh oh!

miss-islington-app Bot commented Sep 8, 2024

Uh oh!

miss-islington-app Bot commented Sep 8, 2024

Uh oh!

miss-islington-app Bot commented Sep 8, 2024

Uh oh!

skirpichev commented Sep 8, 2024

Uh oh!

bedevere-app Bot commented Sep 8, 2024

Uh oh!

bedevere-app Bot commented Sep 8, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

skirpichev commented Jun 27, 2024 •

edited by bedevere-app Bot

Loading