gh-114265: move line number propagation before cfg optimization, remove guarantee_lineno_for_exits#114267
Merged
Merged
Conversation
iritkatriel
force-pushed
the
reorder_flowgraph
branch
from
January 18, 2024 21:33
83f22a5 to
73b08aa
Compare
iritkatriel
requested review from
brettcannon,
ericsnowcurrently,
ncoghlan and
warsaw
as code owners
January 18, 2024 21:33
iritkatriel
commented
Jan 18, 2024
markshannon
approved these changes
Jan 19, 2024
markshannon
left a comment
markshannon
left a comment
Member
There was a problem hiding this comment.
Looks good.
Does this fix any specific bugs, or is this just preparatory?
Member
Author
|
It's preparatory. It will make it possible to fix some open bugs. |
iritkatriel
commented
Jan 19, 2024
markshannon
approved these changes
Jan 19, 2024
iritkatriel
enabled auto-merge (squash)
January 19, 2024 14:47
kulikjak
pushed a commit
to kulikjak/cpython
that referenced
this pull request
Jan 22, 2024
…, remove guarantee_lineno_for_exits (python#114267)
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
…, remove guarantee_lineno_for_exits (python#114267)
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
…, remove guarantee_lineno_for_exits (python#114267)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.