Fix various issues#11
Closed
Matoking wants to merge 3 commits into
Closed
Conversation
Add various missing dependencies that Protontricks and different Winetricks verbs require or prefer: * Many Winetricks verbs require `cabextract` for extracting Windows CAB files. * Winetricks requires a CLI tool to download files and recommends either aria2c or wget, or curl as fallback if neither is available. Use aria2 as it appears to be the preferred option. * Winetricks uses various utilities to extract downloaded archives. The script can download the Windows version of 7-Zip as a fallback in some cases if required tool is unavailable, but this means duplicate installations if multiple Wine prefixes are used (likely). It also produces a warning each time. * yad is preferred for Protontricks GUI, as it supports app icons in the game selector. We already package python-pillow, which goes unused if yad is not used.
zenity-rs does not support `--hide-header`, crashing Protontricks immediately if `yad` is not available. This reverts commit 98ee0eb.
Winetricks needs this for GUI
Member
|
Hi edit: QaidVoid/zenity-rs#42 I've been involved with its development and
And the |
Member
Author
|
Thank you! |
Member
|
there was a problem btw, on archlinux for some reason the This is something already taken into account by |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add missing dependencies to ensure more Winetricks verbs work and that Protontricks is able to display app icons in the game selector (Pillow is a dependency used for generating said app icons, which goes unused if yad is unavailable).
Also revert zenity-rs to upstream zenity, since it causes a crash on startup due to an unimplemented flag.