bz2: refactor filter creation to do parameter validation#22307
Merged
Conversation
ndossche
requested changes
Jul 4, 2026
ndossche
left a comment
ndossche
left a comment
Member
There was a problem hiding this comment.
Looking better. Preferably please when possible try to split this into multiple smaller commits. Code that's both refactored and moved is very hard to review properly and risks introducing regressions.
What I have for you is mostly nits tbh
Girgias
force-pushed
the
bz2_filters
branch
2 times, most recently
from
e00cb38 to
59bf543
Compare
Member
|
CI fails |
Member
Author
|
The failures are unrelated and were due to the bad merge of some iconv tests in the merge up process. |
ndossche
approved these changes
Jul 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And other minor improvements like packing the struct better.
Maybe those should be Type/ValueErrors directly?