Skip to content

Allow parameter export=True for zone export#150

Merged
fformica merged 4 commits into
ns1:masterfrom
lhost:zone-export
Jul 15, 2026
Merged

Allow parameter export=True for zone export#150
fformica merged 4 commits into
ns1:masterfrom
lhost:zone-export

Conversation

@lhost

@lhost lhost commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

With the parameter export=True the output of zone export looks differently:

  • key short_answers becomes 'answers'
  • key 'id' is removed
  • key 'zone_name' is removed

With the parameter export=True the output of zone export looks
differently:

- key `short_answers` becomes 'answers'
- key 'id' is removed
- key 'zone_name' is removed
@bencourliss
bencourliss self-requested a review July 14, 2026 19:39

@bencourliss bencourliss left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the submission. Please fix the linting issues and the test failures.

@lhost

lhost commented Jul 14, 2026

Copy link
Copy Markdown
Contributor Author

@bencourliss Fixed, please run tests again.

@lhost
lhost requested a review from bencourliss July 14, 2026 20:25

@fformica fformica left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhost

lhost commented Jul 15, 2026

Copy link
Copy Markdown
Contributor Author

Can be this PR included into 0.29 release?

@bencourliss bencourliss left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fformica

Copy link
Copy Markdown
Contributor

Can be this PR included into 0.29 release?

Yep, I think we'll publish it later today; feel free to merge or I'll do it when we are about to release :)

@fformica
fformica merged commit 0f1655e into ns1:master Jul 15, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants