lib: deprecate _http_* by bjohansebas · Pull Request #58535 · nodejs/node

bjohansebas · 2025-05-31T19:21:56Z

nodejs-github-bot · 2025-05-31T19:22:01Z

Review requested:

@nodejs/http
@nodejs/net

jasnell · 2025-05-31T23:22:01Z

jasnell · 2025-05-31T23:23:48Z

This one might need a Documentation-only deprecation to start. It's likely going to be too disruptive to go straight to a Runtime deprecation. https://github.com/search?type=code&q=%22require%28%27_http%22

dario-piotrowicz

Yay! thanks for doing this! 🫶

(with this all pesky _modules will be runtime deprecated! 💪)

bjohansebas · 2025-05-31T23:31:09Z

This one might need a Documentation-only deprecation to start. It's likely going to be too disruptive to go straight to a Runtime deprecation. https://github.com/search?type=code&q=%22require%28%27_http%22

Most of them seem to be just forks of Node.js, rather than actually using these undocumented modules.

jasnell · 2025-05-31T23:45:08Z

Most of them seem to be just forks of Node.js....

I wish that were the case. While there are a good number of forks in those search results, it's plain to see that there are a non-trivial number of other projects requiring "_http_common" and friends. We need to assess just how disruptive this will be... but don't get me wrong, I am in favor of deprecated these but it might need to be a slower path. I'd like @nodejs/http folks to weigh in.

codecov · 2025-06-01T00:29:07Z

Codecov Report

❌ Patch coverage is 97.44003% with 143 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.24%. Comparing base (b4c7be3) to head (eb2643c).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
lib/internal/http/server.js	96.50%	48 Missing and 3 partials ⚠️
lib/internal/http/client.js	97.63%	30 Missing ⚠️
lib/internal/http/outgoing.js	97.62%	29 Missing and 1 partial ⚠️
lib/internal/http/agent.js	96.12%	26 Missing and 1 partial ⚠️
lib/internal/http/incoming.js	99.37%	3 Missing ⚠️
lib/internal/http/common.js	99.42%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #58535      +/-   ##
==========================================
+ Coverage   90.23%   90.24%   +0.01%     
==========================================
  Files         741      747       +6     
  Lines      241604   241854     +250     
  Branches    45520    45533      +13     
==========================================
+ Hits       218010   218267     +257     
+ Misses      15120    15113       -7     
  Partials     8474     8474

Files with missing lines	Coverage Δ
lib/_http_agent.js	`100.00% <100.00%> (+3.87%)`	⬆️
lib/_http_client.js	`100.00% <100.00%> (+2.36%)`	⬆️
lib/_http_common.js	`100.00% <100.00%> (+0.57%)`	⬆️
lib/_http_incoming.js	`100.00% <100.00%> (+0.62%)`	⬆️
lib/_http_outgoing.js	`100.00% <100.00%> (+2.37%)`	⬆️
lib/_http_server.js	`100.00% <100.00%> (+3.49%)`	⬆️
lib/http.js	`98.83% <100.00%> (ø)`
lib/https.js	`98.22% <100.00%> (ø)`
lib/internal/child_process.js	`94.73% <100.00%> (ø)`
lib/internal/http2/compat.js	`97.21% <100.00%> (+<0.01%)`	⬆️
... and 8 more

... and 24 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

bjohansebas · 2025-06-14T18:03:35Z

@nodejs/http what are your recommendations?

Ref nodejs#58535

Ref nodejs#58535 Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com>

Ref #58535 Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com> PR-URL: #59293 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>

gurgunday

lgtm

I think we can now move forward with this

nodejs-github-bot · 2026-02-03T03:10:18Z

CI: https://ci.nodejs.org/job/node-test-pull-request/71178/

nodejs-github-bot · 2026-02-03T19:35:46Z

CI: https://ci.nodejs.org/job/node-test-pull-request/71184/

bjohansebas · 2026-04-19T16:59:03Z

@nodejs/tsc could we take a look at this? I can rebase it again, but the PR always ends up stuck without a review.

mcollina · 2026-04-19T19:10:38Z

rebase and add the fast track label

mcollina · 2026-04-19T19:11:49Z

tbh it's not a rebase that is needed but moving the new files

github-actions · 2026-04-19T20:47:28Z

Fast-track has been requested by @bjohansebas. Please 👍 to approve.

github-actions · 2026-04-19T20:51:42Z

The notable-change PRs with changes that should be highlighted in changelogs. label has been added by @bjohansebas.

Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section.

github-actions · 2026-04-19T21:27:26Z

Fast-track has been requested by @bjohansebas. Please 👍 to approve.

github-actions · 2026-04-19T21:30:12Z

Failed to start CI

- Validating Jenkins credentials
✔  Jenkins credentials valid
- Querying data for job/node-test-pull-request/71184/
[SyntaxError: Unexpected token '<', ..."    
  https://github.com/nodejs/node/actions/runs/24639573120

Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com>

nodejs-github-bot added http Issues or PRs related to the http subsystem. needs-ci PRs that need a full CI run. labels May 31, 2025

bjohansebas added the wip Issues and PRs that are still a work in progress. label May 31, 2025

bjohansebas force-pushed the http_internals branch 2 times, most recently from 11b6878 to 329d0a0 Compare May 31, 2025 20:17

bjohansebas added semver-major PRs that contain breaking changes and should be released in the next major version. deprecations Issues and PRs related to deprecations. labels May 31, 2025

bjohansebas marked this pull request as ready for review May 31, 2025 21:29

bjohansebas requested review from dario-piotrowicz, jasnell and mcollina May 31, 2025 21:29

bjohansebas removed the wip Issues and PRs that are still a work in progress. label May 31, 2025

bjohansebas force-pushed the http_internals branch 2 times, most recently from 0ec4ccc to bd305a8 Compare May 31, 2025 23:17

jasnell reviewed May 31, 2025

View reviewed changes

Comment thread benchmark/http/check_is_http_token.js Outdated

dario-piotrowicz reviewed May 31, 2025

View reviewed changes

Comment thread test/parallel/test-warn-http-server-deprecation.js Outdated

Comment thread test/parallel/test-https-server-close-destroy-timeout.js

Comment thread benchmark/http/check_is_http_token.js Outdated

Comment thread benchmark/http/check_invalid_header_char.js Outdated

dario-piotrowicz reviewed Jun 1, 2025

View reviewed changes

Comment thread benchmark/http/check_invalid_header_char.js Outdated

Comment thread lib/_http_common.js

Comment thread test/parallel/test-https-server-close-destroy-timeout.js

bjohansebas added a commit to bjohansebas/node that referenced this pull request Jul 30, 2025

lib: docs deprecate _http_*

d8d2df0

Ref nodejs#58535

bjohansebas added a commit to bjohansebas/node that referenced this pull request Jul 31, 2025

lib: docs deprecate _http_*

df48e6f

Ref nodejs#58535 Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com>

bjohansebas mentioned this pull request Jul 31, 2025

lib: docs deprecate _http_* #59293

Merged

bjohansebas added a commit to bjohansebas/node that referenced this pull request Jul 31, 2025

lib: docs deprecate _http_*

70c3173

Ref nodejs#58535 Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com>

bjohansebas added a commit to bjohansebas/node that referenced this pull request Jul 31, 2025

lib: docs deprecate _http_*

e947fb5

Ref nodejs#58535 Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com>

gurgunday approved these changes Feb 2, 2026

View reviewed changes

bjohansebas added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 3, 2026

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 3, 2026

pimterry approved these changes Feb 3, 2026

View reviewed changes

anonrig approved these changes Apr 19, 2026

View reviewed changes

bjohansebas force-pushed the http_internals branch from 731360d to ec6cb5c Compare April 19, 2026 20:46

bjohansebas added the fast-track PRs that do not need to wait for 72 hours to land. label Apr 19, 2026

bjohansebas added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. notable-change PRs with changes that should be highlighted in changelogs. labels Apr 19, 2026

bjohansebas added request-ci Add this label to start a Jenkins CI on a PR. and removed fast-track PRs that do not need to wait for 72 hours to land. labels Apr 19, 2026

bjohansebas force-pushed the http_internals branch from ec6cb5c to 6177039 Compare April 19, 2026 21:17

anonrig approved these changes Apr 19, 2026

View reviewed changes

bjohansebas added the fast-track PRs that do not need to wait for 72 hours to land. label Apr 19, 2026

github-actions Bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Apr 19, 2026

gurgunday approved these changes Apr 19, 2026

View reviewed changes

bjohansebas force-pushed the http_internals branch 2 times, most recently from dd6d1e7 to de10a15 Compare July 12, 2026 17:21

lib: deprecate _http_*

eb2643c

Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com>

bjohansebas force-pushed the http_internals branch from de10a15 to eb2643c Compare July 12, 2026 19:13

Uh oh!

Uh oh!

Conversation

bjohansebas commented May 31, 2025

Uh oh!

nodejs-github-bot commented May 31, 2025

Uh oh!

Uh oh!

jasnell commented May 31, 2025

Uh oh!

jasnell commented May 31, 2025

Uh oh!

dario-piotrowicz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bjohansebas commented May 31, 2025

Uh oh!

jasnell commented May 31, 2025

Uh oh!

codecov Bot commented Jun 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bjohansebas commented Jun 14, 2025

Uh oh!

gurgunday left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Feb 3, 2026

Uh oh!

nodejs-github-bot commented Feb 3, 2026

Uh oh!

bjohansebas commented Apr 19, 2026

Uh oh!

mcollina commented Apr 19, 2026

Uh oh!

mcollina commented Apr 19, 2026

Uh oh!

github-actions Bot commented Apr 19, 2026

Uh oh!

github-actions Bot commented Apr 19, 2026

Uh oh!

github-actions Bot commented Apr 19, 2026

Uh oh!

github-actions Bot commented Apr 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

codecov Bot commented Jun 1, 2025 •

edited

Loading