Render web search only when enabled#900
Draft
Minghan2005 wants to merge 1 commit into
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Author
|
I hope you pass |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
showSearchBarsetting from whetherorama-dbis targetedshowSearchBar: trueandshowSearchBar: falseoverridesWhy
The web navigation always rendered its search control, even when the generator pipeline did not build an Orama database. In that configuration the control was visible but could not return results.
The resolved configuration now enables search automatically when
orama-dbis part of the target list. Projects that share a remote database or intentionally hide search can still override the derived default explicitly.Validation
node --test --experimental-test-module-mocks "src/**/*.test.mjs"(516 tests passed)eslint . --no-warn-ignored(0 errors; 2 existing warnings inuseOrama.mjs)prettier --check .Closes #891