Skip to content

Run e2e render after release instead of every night#119

Merged
nmbrthirteen merged 1 commit into
mainfrom
cursor/post-release-e2e-render-23e8
Jul 16, 2026
Merged

Run e2e render after release instead of every night#119
nmbrthirteen merged 1 commit into
mainfrom
cursor/post-release-e2e-render-23e8

Conversation

@nmbrthirteen

@nmbrthirteen nmbrthirteen commented Jul 15, 2026

Copy link
Copy Markdown
Owner

What this does

Agrees with running the heavy cross-OS render check when something actually ships, not every morning on an unchanged main.

  • Drops the daily cron
  • Triggers on release: published (after a v* release is cut)
  • Keeps workflow_dispatch for manual runs
  • Renames the workflow to post-release-render (same file)

Merge after #118 so the first post-release run isn’t red on the DM Sans timeout.

How I tested it

  • Workflow YAML review against release.yml (softprops/action-gh-release publishes a GitHub release, which fires release: published)

Checklist

  • npx tsc --noEmit and npm test pass (plus pytest tests/ if you touched the backend)
  • Docs updated if commands or behavior changed
  • No secrets, personal config, or generated output committed

Summary by CodeRabbit

  • Chores
    • Updated automated rendering checks to run after a release is published.
    • Retained the option to trigger rendering checks manually.
    • Removed the nightly scheduled run.

@coderabbitai

coderabbitai Bot commented Jul 15, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@nmbrthirteen, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 51 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 5827c47e-d389-41ec-b583-ee85a5d22ad1

📥 Commits

Reviewing files that changed from the base of the PR and between 0fcdd83 and 1bf7541.

📒 Files selected for processing (1)
  • .github/workflows/nightly.yml
📝 Walkthrough

Walkthrough

The GitHub Actions render workflow now runs when a release is published or manually dispatched instead of on a nightly schedule. An obsolete headless-browser caption renderer comment was removed.

Changes

Post-release render workflow

Layer / File(s) Summary
Post-release workflow trigger and cleanup
.github/workflows/nightly.yml
The workflow name and trigger now target published releases while retaining manual dispatch, and the obsolete renderer comment is removed.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the workflow change from nightly runs to post-release e2e rendering.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cursor/post-release-e2e-render-23e8

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nmbrthirteen
nmbrthirteen marked this pull request as ready for review July 16, 2026 11:42

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
.github/workflows/nightly.yml (1)

1-5: 🧹 Nitpick | 🔵 Trivial

Ensure PR #118 is merged before this PR.

As per PR objectives, remember to merge PR #118 to avoid the initial post-release run failing on the DM Sans timeout.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/nightly.yml around lines 1 - 5, Ensure PR `#118` is merged
before completing this change so the initial post-release-render workflow run
does not fail due to the DM Sans timeout; no changes are needed to the workflow
name.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/nightly.yml:
- Around line 7-9: Update the render job in the nightly workflow with a
job-level condition that runs for release events only when
github.event.release.tag_name starts with “v”, while preserving
workflow_dispatch manual runs. Do not attempt to filter release tags in the on
block.

---

Nitpick comments:
In @.github/workflows/nightly.yml:
- Around line 1-5: Ensure PR `#118` is merged before completing this change so the
initial post-release-render workflow run does not fail due to the DM Sans
timeout; no changes are needed to the workflow name.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 119b5276-7c4e-48c1-8c5b-a878f8f9acc5

📥 Commits

Reviewing files that changed from the base of the PR and between 07c045d and 0fcdd83.

📒 Files selected for processing (1)
  • .github/workflows/nightly.yml

Comment thread .github/workflows/nightly.yml
Daily cron kept firing with no code changes and surfacing runner/font
noise. Gate the same job on release published (and keep manual dispatch).
@nmbrthirteen
nmbrthirteen force-pushed the cursor/post-release-e2e-render-23e8 branch from 0fcdd83 to 1bf7541 Compare July 16, 2026 11:50
@nmbrthirteen
nmbrthirteen merged commit 55c06f3 into main Jul 16, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant