Run e2e render after release instead of every night#119
Conversation
|
Warning Review limit reached
Next review available in: 51 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe GitHub Actions render workflow now runs when a release is published or manually dispatched instead of on a nightly schedule. An obsolete headless-browser caption renderer comment was removed. ChangesPost-release render workflow
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
.github/workflows/nightly.yml (1)
1-5: 🧹 Nitpick | 🔵 TrivialEnsure PR
#118is merged before this PR.As per PR objectives, remember to merge PR
#118to avoid the initial post-release run failing on the DM Sans timeout.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/nightly.yml around lines 1 - 5, Ensure PR `#118` is merged before completing this change so the initial post-release-render workflow run does not fail due to the DM Sans timeout; no changes are needed to the workflow name.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/nightly.yml:
- Around line 7-9: Update the render job in the nightly workflow with a
job-level condition that runs for release events only when
github.event.release.tag_name starts with “v”, while preserving
workflow_dispatch manual runs. Do not attempt to filter release tags in the on
block.
---
Nitpick comments:
In @.github/workflows/nightly.yml:
- Around line 1-5: Ensure PR `#118` is merged before completing this change so the
initial post-release-render workflow run does not fail due to the DM Sans
timeout; no changes are needed to the workflow name.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 119b5276-7c4e-48c1-8c5b-a878f8f9acc5
📒 Files selected for processing (1)
.github/workflows/nightly.yml
Daily cron kept firing with no code changes and surfacing runner/font noise. Gate the same job on release published (and keep manual dispatch).
0fcdd83 to
1bf7541
Compare
What this does
Agrees with running the heavy cross-OS render check when something actually ships, not every morning on an unchanged
main.cronrelease: published(after av*release is cut)workflow_dispatchfor manual runspost-release-render(same file)Merge after #118 so the first post-release run isn’t red on the DM Sans timeout.
How I tested it
release.yml(softprops/action-gh-releasepublishes a GitHub release, which firesrelease: published)Checklist
npx tsc --noEmitandnpm testpass (pluspytest tests/if you touched the backend)Summary by CodeRabbit