Preserve face maps from imported transcripts#116
Merged
Conversation
Keep mixed-layout crop metadata available when processing with --transcript so Riverside-style compositions frame speakers instead of the panel seam. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Drive the real command path in the regression test so imported crop metadata is proven to reach clip rendering. Co-authored-by: Cursor <cursoragent@cursor.com>
Processing with --transcript routed every non-JSON file through the speaker-block parser, so SRT and VTT exports were rejected outright. Detect the format instead, and look the face map up by video content so a hand-corrected transcript keeps the split-screen framing that the first run already computed. Without a cached map the crop falls back to per-clip face tracking, unchanged from before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--transcriptTest plan
venv/bin/python -m pytest tests/test_cli.py -qvenv/bin/python -m pytest tests/ -q(536 passed; 3 pre-existing environment-dependent failures intests/test_ai_fallback.py)Made with Cursor