Honor clean_fillers on agent exports and make the port configurable#112
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
nmbrthirteen
force-pushed
the
audit-4-captions
branch
from
July 13, 2026 11:52
a4fa52d to
c6abb1b
Compare
nmbrthirteen
force-pushed
the
audit-5-mcp
branch
from
July 13, 2026 11:52
e7a665a to
f8f9a11
Compare
nmbrthirteen
force-pushed
the
audit-4-captions
branch
from
July 13, 2026 12:11
c6abb1b to
f0de6b7
Compare
nmbrthirteen
force-pushed
the
audit-5-mcp
branch
from
July 13, 2026 12:11
f8f9a11 to
abf46e1
Compare
nmbrthirteen
force-pushed
the
audit-4-captions
branch
from
July 13, 2026 12:17
f0de6b7 to
29bbd94
Compare
nmbrthirteen
force-pushed
the
audit-5-mcp
branch
from
July 13, 2026 12:17
abf46e1 to
b0309f5
Compare
Every agent-driven render silently skipped filler and dead-air removal: the export route dropped the flag, and the tool schema never even accepted the one its own docs promised. - clean_fillers and keep_caption_overlay flow through, falling back to the studio's own toggle rather than a hardcoded default - PODCLI_PORT works end to end, replacing ~31 hardcoded call sites, so the advice in the port-conflict error is now true - ui-state, corrections, and integrations write atomically, so a crash no longer resets a session to defaults - Terminal jobs evict, subprocesses time out, and kill escalation cannot signal a recycled pid - Clip results carry the submitted bounds, so out-of-order parallel results land on the right clips and progress cannot run backwards - Horizontal batches validate against the horizontal cap
nmbrthirteen
force-pushed
the
audit-5-mcp
branch
from
July 13, 2026 13:52
b0309f5 to
113a845
Compare
Avoid signaling recycled POSIX process groups and use Windows tree termination so timed-out media subprocesses do not survive their parent. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com> # Conflicts: # src/ui/web-server.ts
The Node studio resolves its port as PODCLI_PORT > PORT > 3847, but the Python launcher only read PORT, so `PODCLI_PORT=4000 podcli ui` bound 4000 while the CLI printed and opened 3847. Mirror the resolver in backend/config/server.py, use it for every studio URL the CLI prints or opens, and pin both vars when spawning the studio so the two can't diverge. The MCP web-server path swallowed every error from the render job (empty if body), then re-ran the whole clip/batch through the sync path, so a lost or failed job was invisible and rendered twice. Only an unreachable studio now falls back inline, with a warning; anything else surfaces.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every agent-driven render silently skipped filler and dead-air removal: the
export route dropped the flag, and the tool schema never even accepted the
one its own docs promised.
studio's own toggle rather than a hardcoded default
advice in the port-conflict error is now true
longer resets a session to defaults
signal a recycled pid
land on the right clips and progress cannot run backwards
Part of the product audit. Stacked on
audit-4-captions, so review only this PR's diff and merge in order.