Hold captions through pauses and wait for fonts before rendering#111
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
nmbrthirteen
force-pushed
the
audit-3-render
branch
from
July 13, 2026 11:52
4cbda24 to
4ce71db
Compare
nmbrthirteen
force-pushed
the
audit-4-captions
branch
from
July 13, 2026 11:52
a4fa52d to
c6abb1b
Compare
nmbrthirteen
force-pushed
the
audit-3-render
branch
from
July 13, 2026 12:11
4ce71db to
59fc5fc
Compare
nmbrthirteen
force-pushed
the
audit-4-captions
branch
from
July 13, 2026 12:11
c6abb1b to
f0de6b7
Compare
The active chunk ended at its last word, so captions blinked out during every natural pause and popped back for the next line. - A chunk stays up until the next one starts, capped at 0.4s into a silence so a long pause clears, matching the burn-in renderer - Chunk building lives in one module and breaks on punctuation, speaker change, and long gaps - Rendering waits for the font, and a font that fails to load degrades to a fallback instead of failing every frame - The bundle cache keys on the Remotion version and takes a lock, so a cold start under concurrency cannot serve a half-written bundle
nmbrthirteen
force-pushed
the
audit-3-render
branch
from
July 13, 2026 12:17
59fc5fc to
10cf6f4
Compare
nmbrthirteen
force-pushed
the
audit-4-captions
branch
from
July 13, 2026 12:17
f0de6b7 to
29bbd94
Compare
Use token-owned leases and staging paths so stale owners cannot release or publish over a replacement bundle operation. Co-authored-by: Cursor <cursoragent@cursor.com>
The chunker breaks a caption card on a speaker change, but the words handed to Remotion were rebuilt without the speaker field, so the rule could never fire in a render. The studio preview keeps the field and does break on it, so a diarized transcript chunked one way on screen and another way in the exported MP4.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The active chunk ended at its last word, so captions blinked out during
every natural pause and popped back for the next line.
so a long pause clears, matching the burn-in renderer
change, and long gaps
fallback instead of failing every frame
start under concurrency cannot serve a half-written bundle
Part of the product audit. Stacked on
audit-3-render, so review only this PR's diff and merge in order.