Add "sendInvalidate" request#1367
Merged
WardenGnaw merged 2 commits intoApr 17, 2023
Merged
Conversation
sbobko
marked this pull request as draft
October 31, 2022 14:17
Contributor
|
I'm interested in having this PR merged |
Contributor
Author
|
Hello @iAbadia , Unfortunately, I'm busy right now and I can't spare the time. You can use the code for inspiration and make your own contribution. |
Contributor
|
Thanks @sbobko , I'll do that! |
sbobko
force-pushed
the
sbobko/Add_sendInvalidate_request
branch
2 times, most recently
from
April 3, 2023 15:38
28f9f29 to
c139b02
Compare
WardenGnaw
requested changes
Apr 3, 2023
sbobko
force-pushed
the
sbobko/Add_sendInvalidate_request
branch
from
April 5, 2023 12:01
c139b02 to
0b71abb
Compare
sbobko
marked this pull request as ready for review
April 5, 2023 12:03
sbobko
force-pushed
the
sbobko/Add_sendInvalidate_request
branch
from
April 5, 2023 13:49
0b71abb to
7d7a03c
Compare
WardenGnaw
reviewed
Apr 11, 2023
sbobko
force-pushed
the
sbobko/Add_sendInvalidate_request
branch
from
April 12, 2023 16:02
bfbe2f5 to
05746d6
Compare
WardenGnaw
reviewed
Apr 15, 2023
Co-authored-by: Andrew Wang <waan@microsoft.com>
sbobko
force-pushed
the
sbobko/Add_sendInvalidate_request
branch
from
April 17, 2023 10:49
3f5325b to
9c995d2
Compare
WardenGnaw
approved these changes
Apr 17, 2023
WardenGnaw
left a comment
Member
There was a problem hiding this comment.
LGTM Thanks for the contribution. Once the PR checks pass I'll check it in and it should show in the cpptools changelog when it is in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for OpenDebugAD7 to handle
sendInvalidaterequests which will respond if it successfully fired an InvalidatedEvent to the UI.Here is the schema: