Skip to content

Add "sendInvalidate" request#1367

Merged
WardenGnaw merged 2 commits into
microsoft:mainfrom
sbobko:sbobko/Add_sendInvalidate_request
Apr 17, 2023
Merged

Add "sendInvalidate" request#1367
WardenGnaw merged 2 commits into
microsoft:mainfrom
sbobko:sbobko/Add_sendInvalidate_request

Conversation

@sbobko

@sbobko sbobko commented Oct 31, 2022

Copy link
Copy Markdown
Contributor

This PR adds support for OpenDebugAD7 to handle sendInvalidate requests which will respond if it successfully fired an InvalidatedEvent to the UI.

Here is the schema:

"SendInvalidateRequest": {
    "allOf": [
        {
            "$ref": "#/definitions/Request"
        },
        {
            "type": "object",
            "properties": {
               "areas": {
                  "type": "array",
                  "description": "Set of logical areas that got invalidated. This property has a hint characteristic: a client can only be expected to make a 'best effort' in honoring the areas but there are no guarantees. If this property is missing, empty, or if values are not understood, the client should assume a single value `all`.",
                  "items": {
                     "$ref": "#/definitions/InvalidatedAreas"
                  }
               },
                "threadId": {
                    "type": "int",
                },
                "stackFrameId": {
                    "type": "int",
                },
            },
            "required": [
                "areas"
            ]
        }
    ]
},

@iAbadia

iAbadia commented Mar 21, 2023

Copy link
Copy Markdown
Contributor

I'm interested in having this PR merged

@sbobko

sbobko commented Mar 21, 2023

Copy link
Copy Markdown
Contributor Author

Hello @iAbadia , Unfortunately, I'm busy right now and I can't spare the time. You can use the code for inspiration and make your own contribution.

@iAbadia

iAbadia commented Mar 21, 2023

Copy link
Copy Markdown
Contributor

Thanks @sbobko , I'll do that!

@sbobko
sbobko force-pushed the sbobko/Add_sendInvalidate_request branch 2 times, most recently from 28f9f29 to c139b02 Compare April 3, 2023 15:38
Comment thread src/OpenDebugAD7/AD7DebugSession.cs Outdated
Comment thread src/OpenDebugAD7/AD7DebugSession.cs Outdated
Comment thread src/OpenDebugAD7/AD7DebugSession.cs Outdated
@sbobko
sbobko force-pushed the sbobko/Add_sendInvalidate_request branch from c139b02 to 0b71abb Compare April 5, 2023 12:01
@sbobko
sbobko marked this pull request as ready for review April 5, 2023 12:03
@sbobko
sbobko force-pushed the sbobko/Add_sendInvalidate_request branch from 0b71abb to 7d7a03c Compare April 5, 2023 13:49
@sbobko
sbobko requested a review from WardenGnaw April 5, 2023 13:50
Comment thread src/OpenDebugAD7/AD7DebugSession.cs Outdated
@sbobko
sbobko force-pushed the sbobko/Add_sendInvalidate_request branch from bfbe2f5 to 05746d6 Compare April 12, 2023 16:02
author Sergey <sergey.bobko@intel.com> 1667223527 -0700
committer Sergey Bobko <sergey.bobko@intel.com> 1680535841 +0000

Add "sendInvalidate" request
@sbobko
sbobko requested a review from WardenGnaw April 12, 2023 16:10
Comment thread src/OpenDebugAD7/AD7DebugSession.cs Outdated
Comment thread src/OpenDebugAD7/AD7DebugSession.cs Outdated
Co-authored-by: Andrew Wang <waan@microsoft.com>
@sbobko
sbobko force-pushed the sbobko/Add_sendInvalidate_request branch from 3f5325b to 9c995d2 Compare April 17, 2023 10:49
@sbobko
sbobko requested a review from WardenGnaw April 17, 2023 14:40

@WardenGnaw WardenGnaw left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks for the contribution. Once the PR checks pass I'll check it in and it should show in the cpptools changelog when it is in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants