Skip to content
This repository was archived by the owner on May 7, 2026. It is now read-only.

perf: Enhance benchmark script with total_rows and tests#1949

Closed
shuoweil wants to merge 8 commits into
mainfrom
shuowei-benchmark-add-total-rows
Closed

perf: Enhance benchmark script with total_rows and tests#1949
shuoweil wants to merge 8 commits into
mainfrom
shuowei-benchmark-add-total-rows

Conversation

@shuoweil

@shuoweil shuoweil commented Jul 30, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

perf: Enhance benchmark script with total_rows and tests

  1. Updated the benchmark script to include the total_rows metric.
  2. Added a test to verify that the benchmark script is working correctly.

@shuoweil shuoweil self-assigned this Jul 30, 2025
@shuoweil
shuoweil requested review from a team July 30, 2025 03:57
@product-auto-label product-auto-label Bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Jul 30, 2025
@shuoweil
shuoweil force-pushed the shuowei-benchmark-add-total-rows branch 2 times, most recently from 10535d8 to d879f7f Compare July 30, 2025 22:07
@shuoweil shuoweil added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 31, 2025
@bigframes-bot bigframes-bot removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 31, 2025
@shuoweil
shuoweil force-pushed the shuowei-benchmark-add-total-rows branch 7 times, most recently from 94bbaa0 to fc64df6 Compare August 6, 2025 21:08
@shuoweil
shuoweil force-pushed the shuowei-benchmark-add-total-rows branch 2 times, most recently from e2361bd to f764993 Compare August 8, 2025 19:59
@product-auto-label product-auto-label Bot added size: s Pull request size is small. and removed size: m Pull request size is medium. labels Aug 8, 2025
@shuoweil
shuoweil force-pushed the shuowei-benchmark-add-total-rows branch from f764993 to 1fec577 Compare August 8, 2025 20:59
@product-auto-label product-auto-label Bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Aug 8, 2025
@shuoweil
shuoweil force-pushed the shuowei-benchmark-add-total-rows branch from 1fec577 to fb93fd3 Compare August 9, 2025 00:09
@shuoweil shuoweil mentioned this pull request Aug 11, 2025
Merged
@tswast

tswast commented Aug 11, 2025

Copy link
Copy Markdown
Contributor

Not necessary.

@tswast tswast closed this Aug 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@tswast tswast Awaiting requested review from tswast
@TrevorBergeron TrevorBergeron Awaiting requested review from TrevorBergeron

Assignees

@shuoweil shuoweil

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shuoweil @tswast @bigframes-bot