fix(integrations): declare kiro-cli multi-install safe#3477
Open
Quratulain-bilal wants to merge 1 commit into
Open
fix(integrations): declare kiro-cli multi-install safe#3477Quratulain-bilal wants to merge 1 commit into
Quratulain-bilal wants to merge 1 commit into
Conversation
kiro-cli uses a fully isolated .kiro/ root and .kiro/prompts command dir, a stable "." separator with no dynamic paths, and a dedicated install manifest - it meets every documented multi-install-safe criterion. but the flag was never set, so co-installing it (e.g. alongside claude) left `integration status` permanently in ERROR (unsafe-multi-install) with no way to resolve it; --force bypasses the install gate but not the status finding. set multi_install_safe = True. the registry contract tests auto-parametrize over every safe integration and now prove kiro-cli's roots, command dirs, and install manifests are disjoint from all other safe integrations (365 pass). added an explicit assertion in the kiro-cli test file and listed it in the multi-install-safe docs table.
Contributor
There was a problem hiding this comment.
Pull request overview
Declares Kiro CLI safe for co-installation and documents the behavior.
Changes:
- Enables
multi_install_safefor Kiro CLI. - Adds a regression assertion.
- Adds Kiro CLI to the safety reference table.
Show a summary per file
| File | Description |
|---|---|
src/specify_cli/integrations/kiro_cli/__init__.py |
Enables safe multi-installation. |
tests/integrations/test_integration_kiro_cli.py |
Verifies the safety declaration. |
docs/reference/integrations.md |
Documents Kiro CLI, but contains a safety-criteria inconsistency. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 3/3 changed files
- Comments generated: 1
- Review effort level: Medium
| | `gemini` | `.gemini/commands`, `GEMINI.md` | | ||
| | `junie` | `.junie/commands`, `.junie/AGENTS.md` | | ||
| | `kilocode` | `.kilocode/workflows`, `.kilocode/rules/specify-rules.md` | | ||
| | `kiro-cli` | `.kiro/prompts` | |
mnriem
requested changes
Jul 13, 2026
mnriem
left a comment
mnriem
left a comment
Collaborator
There was a problem hiding this comment.
Please address Copilot feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #3471
kiro-cli uses a fully isolated
.kiro/root and.kiro/promptscommand dir, a stable.separator with no dynamic paths, and a dedicated install manifest — it meets every documented multi-install-safe criterion. butmulti_install_safewas never set onKiroCliIntegration, so co-installing it (e.g. alongside claude) leftspecify integration statuspermanently in ERROR (unsafe-multi-install) with no way to resolve it.--forcebypasses the install-time gate but not the status finding.fix: set
multi_install_safe = TrueonKiroCliIntegration.i verified the isolation rather than trusting the flag: the registry contract tests in
tests/integrations/test_registry.pyauto-parametrize over every declared-safe integration and check pairwise-disjoint agent roots, command dirs, and (via a real init+install) install manifests. with kiro-cli added they still all pass (365 tests), which empirically proves.kiro/doesn't collide with any other safe integration.also added an explicit
multi_install_safe is Trueassertion in the kiro-cli test file (fails on the pre-fix code) and listed kiro-cli in the multi-install-safe docs table.