Skip to content

feat(dashboards): Avoid issue assignee row fetches#115296

Merged
scttcper merged 4 commits into
masterfrom
scttcper/dashboard-assignee-requests
May 11, 2026
Merged

feat(dashboards): Avoid issue assignee row fetches#115296
scttcper merged 4 commits into
masterfrom
scttcper/dashboard-assignee-requests

Conversation

@scttcper

Copy link
Copy Markdown
Member

Issue dashboard tables were fetching the full issue once per assignee cell just to render and update assignment state.

Use the row payload for the dashboard assignee cell instead, and keep the post-assignment display update local to that dashboard wrapper. The shared assignment mutation still updates the normal useGroup cache for issue detail consumers.

Issue dashboard tables were fetching the full issue once per assignee cell just to render and update assignment state.

Use the row payload for the dashboard assignee cell instead, and keep the post-assignment display update local to that dashboard wrapper. The shared assignment mutation still updates the normal useGroup cache for issue detail consumers.

Co-authored-by: Codex GPT-5 <noreply@openai.com>
@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label May 11, 2026
@github-actions

github-actions Bot commented May 11, 2026

Copy link
Copy Markdown
Contributor

📊 Type Coverage Diff

✅ No new type safety issues introduced. Coverage: 93.47%

Dashboard issue rows were carrying assignee and link objects directly on TableDataRow, which pushed us toward casts because those rows are meant to stay tabular.

Keep the rows scalar and carry issue-only renderer data in table meta instead. Also preserve custom table meta when converting to tabular data so the issue renderers can read it.

Co-Authored-By: Codex GPT-5 <noreply@openai.com>
@scttcper scttcper changed the title perf(dashboards): Avoid issue assignee row fetches feat(dashboards): Avoid issue assignee row fetches May 11, 2026
@scttcper scttcper marked this pull request as ready for review May 11, 2026 18:27
@scttcper scttcper requested review from a team as code owners May 11, 2026 18:27

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 2587d94. Configure here.

Comment thread static/app/utils/dashboards/issueFieldRenderers.tsx
team: Team;
};

type AssigneeGroup = Pick<Group, 'assignedTo' | 'id' | 'owners'> & {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason this is defined twice? Can we export one of them?

The review feedback called out a couple of duplicated local types that could drift.

Export the assignee group shape from the dropdown and the issue row metadata shape from the renderer, then reuse those in the nearby consumers. Same behavior, less copy paste.

Co-Authored-By: Codex GPT-5 <noreply@openai.com>
@scttcper scttcper enabled auto-merge (squash) May 11, 2026 20:24
@scttcper scttcper merged commit cc13b67 into master May 11, 2026
74 checks passed
@scttcper scttcper deleted the scttcper/dashboard-assignee-requests branch May 11, 2026 20:30
nikkikapadia pushed a commit that referenced this pull request May 12, 2026
Issue dashboard tables were fetching the full issue once per assignee
cell just to render and update assignment state.

Use the row payload for the dashboard assignee cell instead, and keep
the post-assignment display update local to that dashboard wrapper. The
shared assignment mutation still updates the normal useGroup cache for
issue detail consumers.
@github-actions github-actions Bot locked and limited conversation to collaborators May 27, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants