Skip to content

feat(issues): Clean up empty state project lookup#114652

Merged
scttcper merged 5 commits into
masterfrom
scttcper/no-groups-query
May 5, 2026
Merged

feat(issues): Clean up empty state project lookup#114652
scttcper merged 5 commits into
masterfrom
scttcper/no-groups-query

Conversation

@scttcper

@scttcper scttcper commented May 1, 2026

Copy link
Copy Markdown
Member

Reworks the issues empty state handler while cleaning up the slow project lookup path.

removes a class component and speeds up the project query by passing collapse query parameters and moves it to react query.

The issues empty state was always fetching one project summary, even when the result was only needed for the awaiting-events path. That hit the project summary serializer and could run the latest deploys query for no useful reason.

Move the component to React Query, only fetch the project when we're actually rendering AwaitingEvents, and collapse latestDeploys when we do need it.

Co-Authored-By: Codex GPT-5 <noreply@openai.com>
@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label May 1, 2026
@scttcper scttcper changed the title perf(issues): Avoid latest deploys in empty state perf(issues): Clean up empty state project lookup May 1, 2026
@scttcper scttcper changed the title perf(issues): Clean up empty state project lookup feat(issues): Clean up empty state project lookup May 1, 2026
@scttcper scttcper marked this pull request as ready for review May 1, 2026 22:50
@scttcper scttcper requested a review from a team as a code owner May 1, 2026 22:50
@scttcper scttcper requested review from a team May 1, 2026 22:50
Comment thread static/app/views/issueList/noGroupsHandler/index.tsx Outdated
The react-query cleanup accidentally required the project lookup to return at least one project before showing the waiting-for-events state.

Render the waiting state whenever the org has not sent a first event, and add a regression test for orgs with no projects yet.

Co-Authored-By: Codex <noreply@openai.com>
@github-actions

github-actions Bot commented May 5, 2026

Copy link
Copy Markdown
Contributor

📊 Type Coverage Diff

✅ No new type safety issues introduced. Coverage: 93.40%

@scttcper scttcper merged commit 2c2b50d into master May 5, 2026
72 checks passed
@scttcper scttcper deleted the scttcper/no-groups-query branch May 5, 2026 17:17
@github-actions github-actions Bot locked and limited conversation to collaborators May 21, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants