fix(error-reporting): Silence ValidationError in telemetry#1233
Open
sentry[bot] wants to merge 1 commit into
Open
fix(error-reporting): Silence ValidationError in telemetry#1233sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ValidationError instances, which indicate malformed user input (e.g., too many positional arguments), were being reported to Sentry as issues. These errors are not CLI bugs but user mistakes and should be silenced.
This change adds
ValidationErrorto the list of errors handled byclassifySilenced()insrc/lib/error-reporting.ts, preventing them from being sent to Sentry. This addresses CLI-1AN.Fixes CLI-1AN
Comment
@sentry <feedback>on this PR to have Autofix iterate on the changes.