fix(release): pin build.yml dispatch to the release tag ref#90
Open
EtienneLescot wants to merge 1 commit into
Open
fix(release): pin build.yml dispatch to the release tag ref#90EtienneLescot wants to merge 1 commit into
EtienneLescot wants to merge 1 commit into
Conversation
prerelease.yml triggered build.yml without --ref, so the build ran on the
default branch (main), where package.json is still the previous stable
version. The RC version bump lives only on the release branch / RC tag, so
build.yml's publish-release guard rejected it ("package.json version 1.6.0
does not match 1.7.0-rc.1 from tag v1.7.0-rc.1") and no release was created.
Pass --ref so the build checks out the tag's tree (bumped package.json +
frozen code). Apply the same pin in promote.yml for the stable build, which
previously only worked because the main-merge happened to leave main at the
stable version first.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughRelease workflows now explicitly dispatch ChangesRelease build ref pinning
Estimated code review effort: 1 (Trivial) | ~3 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Cutting v1.7.0-rc.1 from main via
prerelease.ymlcreated the tag and frozenrelease/v1.7.0-rc.1branch correctly, but the build it triggered failed at publish:Root cause:
prerelease.yml's Trigger build workflow step rangh workflow run build.ymlwithout--ref, so the build dispatched on the default branch (main), wherepackage.jsonis still the previous stable version (1.6.0). The RC version bump lives only on the release branch / RC tag, sobuild.yml'spublish-releaseversion guard rejected it and no GitHub release was created. The installer jobs also stamped the wrong version (1.6.0).The v1.7.0-rc.1 pre-release was recovered manually by re-dispatching
build.yml --ref v1.7.0-rc.1; it is now published. This PR fixes the pipeline so no manual recovery is needed next time.Fix
prerelease.yml: add--ref "${RC_TAG}"so the build checks out the RC tag's tree (bumpedpackage.json+ frozen code).promote.yml: add--ref "${STABLE_TAG}"for the same reason. Stable builds previously only passed because the preceding main-merge happened to leavemainat the stable version — pinning the tag makes it robust and correctly enables signing/notarization (the stable tag has no-).Verification
build.yml --ref v1.7.0-rc.1 -f release_tag=v1.7.0-rc.1(the equivalent of the fixed dispatch) ran green across Windows/macOS(arm64+x64)/Linux and publishedv1.7.0-rc.1as a pre-release with 6 assets.🤖 Generated with Claude Code
Summary by CodeRabbit