fix(req): normalize forwarded protocol casing#7330
Open
lin-hongkuan wants to merge 1 commit into
Open
Conversation
bjohansebas
reviewed
Jul 12, 2026
bjohansebas
left a comment
bjohansebas
left a comment
Member
There was a problem hiding this comment.
I'd suggest evaluating this for Express 6. The closest guidance we have is RFC 3986, Section 3.1, which allows both http and HTTP, although the lowercase form is still the preferred canonical form.
There isn't an issue requesting this, and this suggestion came purely from AI, so I'll leave it open as something to consider in the future.
https://www.rfc-editor.org/rfc/rfc3986.html#section-3.1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This normalizes trusted
X-Forwarded-Protovalues to lowercase before exposingreq.protocol, soreq.securehandlesHTTPSthe same ashttps.The regression tests cover both
req.protocolandreq.securewith uppercase forwarded protocol input.Validation:
npx mocha --require test/support/env --check-leaks test/req.protocol.js test/req.secure.jsnpm run lintgit diff --checkAI-assisted: Codex helped prepare this focused change; I reviewed the diff and ran the validation above before submitting.