Skip to content

Only generate types when requested#631

Closed
marvinhagemeister wants to merge 1 commit into
masterfrom
ts-optional-types
Closed

Only generate types when requested#631
marvinhagemeister wants to merge 1 commit into
masterfrom
ts-optional-types

Conversation

@marvinhagemeister

Copy link
Copy Markdown
Collaborator

This PR changes the default behaviour to only generate types when the types or typings field was found in package.json.

Replaces #589 .

@ForsakenHarmony

Copy link
Copy Markdown
Collaborator

This seems to kinda be the inverse of #589?

@developit

Copy link
Copy Markdown
Owner

I think this needs the emitDeclaration tweak from #589 - currently if there are no .ts files, the typescript rollup plugin doesn't get run. Also the allowJs bit (though that could perhaps be on-by-default).

@marvinhagemeister

Copy link
Copy Markdown
Collaborator Author

True, looks like I misunderstood the original PR 🙈

@developit

Copy link
Copy Markdown
Owner

lol not at all, I'll try to make this change there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants