Skip to content

feat: add variables and API Key support#2

Merged
sachyco merged 5 commits into
mainfrom
cb-214-add-api-key-support-client-sdks
Jul 31, 2023
Merged

feat: add variables and API Key support#2
sachyco merged 5 commits into
mainfrom
cb-214-add-api-key-support-client-sdks

Conversation

@sachyco

@sachyco sachyco commented Jul 31, 2023

Copy link
Copy Markdown
Contributor

Changes:

  • Add API key to header
  • Add variables argument to requests
  • Add best_result convenience property to CompletionResponse
  • Improve README & examples.
  • Fix truncateVariables argument (I set to to a bool before for some reason?

@heikir heikir left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Comment thread commonbase/completion.py
) -> requests.Response:
if api_key is None:
raise CommonbaseException(
"A Commonbase API key must be provided with every request."

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add link to where you can generate a new key?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will open an issue to add this once we merge the API Key PR in the monorepo

@sachyco
sachyco merged commit 0c3256b into main Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants