chore(backend): Enforce request param in authenticateRequest#2122
Merged
Conversation
🦋 Changeset detectedLatest commit: eaa8e1b The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
LekoArts
reviewed
Nov 14, 2023
dimkl
force-pushed
the
sdk-782-drop-deprecations-backend
branch
from
November 14, 2023 15:37
9be55f9 to
07edf5b
Compare
dimkl
force-pushed
the
sdk-784-enforce-request-param
branch
from
November 14, 2023 15:39
a2ce60e to
4c80b1a
Compare
dimkl
force-pushed
the
sdk-782-drop-deprecations-backend
branch
3 times, most recently
from
November 15, 2023 14:16
6b8d70b to
92bbeb9
Compare
dimkl
force-pushed
the
sdk-782-drop-deprecations-backend
branch
from
November 16, 2023 10:47
92bbeb9 to
53bef9c
Compare
dimkl
force-pushed
the
sdk-784-enforce-request-param
branch
2 times, most recently
from
November 16, 2023 17:08
d45a8e4 to
6e54944
Compare
anagstef
approved these changes
Nov 16, 2023
…pes dependencies Instead of passing the `AuthenticateRequestOptions` down the dependency tree `authenticateRequest => interstitialRule => AuthStatus => AuthObjects`, we change the approach to bottom-up by definiting types per layer and importing them to the parent layer. Also options of parent layers extend the options of child layers.
dimkl
force-pushed
the
sdk-784-enforce-request-param
branch
2 times, most recently
from
November 16, 2023 21:20
b08abaa to
90a6ff9
Compare
dimkl
force-pushed
the
sdk-784-enforce-request-param
branch
from
November 16, 2023 21:21
90a6ff9 to
eaa8e1b
Compare
dimkl
added this pull request to the merge queue
Nov 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changes:
headersorcookiesof requestrequestparamauthenticateRequestfrom the options used internallyChecklist
npm testruns as expected.npm run buildruns as expected.Type of change
Packages affected
@clerk/backend@clerk/chrome-extension@clerk/clerk-js@clerk/clerk-expo@clerk/fastifygatsby-plugin-clerk@clerk/localizations@clerk/nextjs@clerk/clerk-react@clerk/remix@clerk/clerk-sdk-node@clerk/shared@clerk/themes@clerk/typesbuild/tooling/chore