chore(clerk-js): Introduce Form.PasswordInput, InputGroup, Checkbox#2087
Merged
Conversation
🦋 Changeset detectedLatest commit: 9cbb4a6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
panteliselef
changed the title
panteliselef
marked this pull request as ready for review
November 9, 2023 09:02
panteliselef
force-pushed
the
elef/sdk-674-form-password-checkbox-group
branch
from
November 9, 2023 09:02
39d30d2 to
966e2c6
Compare
nikosdouvlis
requested changes
Nov 9, 2023
nikosdouvlis
left a comment
nikosdouvlis
left a comment
Member
There was a problem hiding this comment.
@panteliselef You will need to apply these changes to the ui-retheme directory. I will share more info within the day
panteliselef
force-pushed
the
elef/sdk-674-form-password-checkbox-group
branch
from
November 13, 2023 11:13
966e2c6 to
901c7d3
Compare
Contributor
Author
@nikosdouvlis Do u mind unblocking this ? The changes u requested have been pushed. |
These components will be a direct replacement of Form.Control
…acement of Form.Control
panteliselef
force-pushed
the
elef/sdk-674-form-password-checkbox-group
branch
from
November 16, 2023 09:10
901c7d3 to
9cbb4a6
Compare
nikosdouvlis
approved these changes
Nov 16, 2023
dimkl
approved these changes
Nov 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR handles the internal refactor of internal form components.
Form.CheckboxForm.InputGroupForm.PasswordInputChanges are applied to both ui and ui.retheme dirs
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change
Packages affected
@clerk/backend@clerk/chrome-extension@clerk/clerk-js@clerk/clerk-expo@clerk/fastifygatsby-plugin-clerk@clerk/localizations@clerk/nextjs@clerk/clerk-react@clerk/remix@clerk/clerk-sdk-node@clerk/shared@clerk/themes@clerk/typesbuild/tooling/chore