Skip to content

fix(clerk-js): Use strict equality operator to check for lockout erro…#2072

Merged
yourtallness merged 1 commit into
mainfrom
yourtallness/fix_handle_redirect_callback_equality_check
Nov 7, 2023
Merged

fix(clerk-js): Use strict equality operator to check for lockout erro…#2072
yourtallness merged 1 commit into
mainfrom
yourtallness/fix_handle_redirect_callback_equality_check

Conversation

@yourtallness

Copy link
Copy Markdown
Contributor

…rs in handleRedirectCallback

Description

Using strict equality === instead of ==.

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Packages affected

  • @clerk/backend
  • @clerk/chrome-extension
  • @clerk/clerk-js
  • @clerk/clerk-expo
  • @clerk/fastify
  • gatsby-plugin-clerk
  • @clerk/localizations
  • @clerk/nextjs
  • @clerk/clerk-react
  • @clerk/remix
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/themes
  • @clerk/types
  • build/tooling/chore

@yourtallness
yourtallness requested a review from a team as a code owner November 7, 2023 14:20
@changeset-bot

changeset-bot Bot commented Nov 7, 2023

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: b71da29

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@clerk/clerk-js Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@yourtallness
yourtallness force-pushed the yourtallness/fix_handle_redirect_callback_equality_check branch from d87b2a9 to b71da29 Compare November 7, 2023 14:24
@yourtallness
yourtallness added this pull request to the merge queue Nov 7, 2023
Merged via the queue into main with commit 034abeb Nov 7, 2023
@yourtallness
yourtallness deleted the yourtallness/fix_handle_redirect_callback_equality_check branch November 7, 2023 14:44
yourtallness added a commit that referenced this pull request Nov 7, 2023
…rs in handleRedirectCallback (#2072)

(cherry picked from commit 034abeb)
github-merge-queue Bot pushed a commit that referenced this pull request Nov 7, 2023
…rs in handleRedirectCallback (#2072) (#2075)

(cherry picked from commit 034abeb)

Co-authored-by: Mark Pitsilos <mark.pitsilos@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants